| Message ID | 20241107033817.1654163-1-wei.fang@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add more feautues for ENETC v4 - round 1 | expand |
On 2024-11-07 at 09:08:12, Wei Fang (wei.fang@nxp.com) wrote: > Compared to ENETC v1 (LS1028A), ENETC v4 (i.MX95) adds more features, and > some features are configured completely differently from v1. In order to > more fully support ENETC v4, these features will be added through several > rounds of patch sets. This round adds these features, such as Tx and Rx > checksum offload, increase maximum chained Tx BD number and Large send > offload (LSO). > > Wei Fang (5): > net: enetc: add Rx checksum offload for i.MX95 ENETC > net: enetc: add Tx checksum offload for i.MX95 ENETC > net: enetc: update max chained Tx BD number for i.MX95 ENETC > net: enetc: add LSO support for i.MX95 ENETC PF > net: enetc: add UDP segmentation offload support > Can you refactor the patches in a way that "ndev->hw_features" set in corresponding patch. Setting NETIF_F_HW_CSUM in "net: enetc: add UDP segmentation offload support" does not look good to me. Thanks, Hariprasad k > drivers/net/ethernet/freescale/enetc/enetc.c | 345 ++++++++++++++++-- > drivers/net/ethernet/freescale/enetc/enetc.h | 32 +- > .../net/ethernet/freescale/enetc/enetc4_hw.h | 22 ++ > .../net/ethernet/freescale/enetc/enetc_hw.h | 31 +- > .../freescale/enetc/enetc_pf_common.c | 16 +- > .../net/ethernet/freescale/enetc/enetc_vf.c | 7 +- > 6 files changed, 419 insertions(+), 34 deletions(-) > > -- > 2.34.1 > >
> -----Original Message----- > From: Hariprasad Kelam <hkelam@marvell.com> > Sent: 2024年11月7日 17:12 > To: Wei Fang <wei.fang@nxp.com> > Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; Vladimir Oltean > <vladimir.oltean@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>; > andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com; > kuba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; imx@lists.linux.dev > Subject: Re: [PATCH net-next 0/5] Add more feautues for ENETC v4 - round 1 > > On 2024-11-07 at 09:08:12, Wei Fang (wei.fang@nxp.com) wrote: > > Compared to ENETC v1 (LS1028A), ENETC v4 (i.MX95) adds more features, > > and some features are configured completely differently from v1. In > > order to more fully support ENETC v4, these features will be added > > through several rounds of patch sets. This round adds these features, > > such as Tx and Rx checksum offload, increase maximum chained Tx BD > > number and Large send offload (LSO). > > > > Wei Fang (5): > > net: enetc: add Rx checksum offload for i.MX95 ENETC > > net: enetc: add Tx checksum offload for i.MX95 ENETC > > net: enetc: update max chained Tx BD number for i.MX95 ENETC > > net: enetc: add LSO support for i.MX95 ENETC PF > > net: enetc: add UDP segmentation offload support > > > > Can you refactor the patches in a way that "ndev->hw_features" set in > corresponding patch. > > > Setting NETIF_F_HW_CSUM in "net: enetc: add UDP segmentation offload > support" does not look good to me. > Sorry, I don't quite understand. I only set NETIF_F_GSO_UDP_L4 in the patch. NETIF_F_HW_CSUM was already set before this patch set.