| Message ID | 20241108-remove_vic_resource_limits-v3-0-3ba8123bcffc@cisco.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | enic: Use all the resources configured on VIC | expand |
On Fri, 08 Nov 2024 21:47:46 +0000 Nelson Escobar wrote: > Allow users to configure and use more than 8 rx queues and 8 tx queues > on the Cisco VIC. > > This series changes the maximum number of tx and rx queues supported > from 8 to the hardware limit of 256, and allocates memory based on the > number of resources configured on the VIC. You don't seem to be responding to feedback. You don't have to agree with all the feedback you get (unless its from the maintainers ;)) but if you don't I'll just assume that you take it at face value and will address..
> On Nov 12, 2024, at 6:30 PM, Jakub Kicinski <kuba@kernel.org> wrote: > > On Fri, 08 Nov 2024 21:47:46 +0000 Nelson Escobar wrote: >> Allow users to configure and use more than 8 rx queues and 8 tx queues >> on the Cisco VIC. >> >> This series changes the maximum number of tx and rx queues supported >> from 8 to the hardware limit of 256, and allocates memory based on the >> number of resources configured on the VIC. > > You don't seem to be responding to feedback. You don't have to agree > with all the feedback you get (unless its from the maintainers ;)) > but if you don't I'll just assume that you take it at face value > and will address.. > -- > pw-bot: cr Yeah, I have to agree that I haven’t been too responsive to feedback. In this particular case, the long weekend in the US played a role, but honestly, I probably would have followed the same pattern. I’ll try to be a bit more responsive in the future. Nelson.
Allow users to configure and use more than 8 rx queues and 8 tx queues on the Cisco VIC. This series changes the maximum number of tx and rx queues supported from 8 to the hardware limit of 256, and allocates memory based on the number of resources configured on the VIC. Signed-off-by: Nelson Escobar <neescoba@cisco.com> --- Changes in v3: - Per Jakub's suggestions, split commit 5 into smaller commits and use net_get_num_default_rss_queues() to set the number of RQs used. - Fixed an issue with commit 2 caught during testing with a missing changed needed in enic_init_vnic_resources(). - Link to v2: https://lore.kernel.org/r/20241024-remove_vic_resource_limits-v2-0-039b8cae5fdd@cisco.com Changes in v2: - Followed Kalesh's suggestions: removed redundant NULL assigments, returning -ENOMEM directly - Reviewed-by tag for Simon Horman <horms@kernel.org> - Marked Satish Kharat and John Daley as co-developers to better reflect their role in this patch set - Link to v1: https://lore.kernel.org/r/20241022041707.27402-2-neescoba@cisco.com --- Nelson Escobar (7): enic: Create enic_wq/rq structures to bundle per wq/rq data enic: Make MSI-X I/O interrupts come after the other required ones enic: Save resource counts we read from HW enic: Allocate arrays in enic struct based on VIC config enic: Adjust used MSI-X wq/rq/cq/interrupt resources in a more robust way enic: Move enic resource adjustments to separate function enic: Move kdump check into enic_adjust_resources() drivers/net/ethernet/cisco/enic/enic.h | 62 ++-- drivers/net/ethernet/cisco/enic/enic_ethtool.c | 8 +- drivers/net/ethernet/cisco/enic/enic_main.c | 386 +++++++++++++++---------- drivers/net/ethernet/cisco/enic/enic_res.c | 42 +-- 4 files changed, 299 insertions(+), 199 deletions(-) --- base-commit: 6f07cd8301706b661776074ddc97c991d107cc91 change-id: 20241023-remove_vic_resource_limits-eaa64f9e65fb Best regards,