mbox series

[iproute2-next,v1,0/6] iplink_can: preparation before introduction of CAN XL

Message ID 20241112172812.590665-8-mailhol.vincent@wanadoo.fr (mailing list archive)
Headers show
Series iplink_can: preparation before introduction of CAN XL | expand

Message

Vincent Mailhol Nov. 12, 2024, 5:27 p.m. UTC
An RFC was sent last weekend to kick-off the discussion of the
introduction of CAN XL: [1] for the kernel side and [2] for the
iproute2 interface. While the series received some positive feedback,
it is far from completion. Some work is still needed to:

  - adjust the nesting of the IFLA_CAN_XL_DATA_BITTIMING_CONST in the
    netlink interface

  - add the CAN XL PWM configuration

and this TODO list may grow if more feedback is received.

Regardless of this, the RFC started with a set of trivial patches to
do some clean-up and some renaming in preparation of the introduction
of CAN XL.

This series just contains those preparation patches which were cherry
picked from the RFC.

The goal is to have those merged first to remove some overhead from
the netlink CAN XL main series before tacking care of the other
comments.

[1] [RFC] can: netlink: add CAN XL
Link: https://lore.kernel.org/linux-can/20241110155902.72807-16-mailhol.vincent@wanadoo.fr/

[2] [RFC] iplink_can: add CAN XL
Link: https://lore.kernel.org/linux-can/20241110160406.73584-10-mailhol.vincent@wanadoo.fr/

Vincent Mailhol (6):
  iplink_can: remove unused FILE *f parameter in three functions
  iplink_can: reduce the visibility of tdc in can_parse_opt()
  iplink_can: remove newline at the end of invarg()'s messages
  iplink_can: use invarg() instead of fprintf()
  iplink_can: add struct can_tdc
  iplink_can: rename dbt into fd_dbt in can_parse_opt()

 ip/iplink_can.c | 107 +++++++++++++++++++++++++-----------------------
 1 file changed, 56 insertions(+), 51 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 18, 2024, 5 p.m. UTC | #1
Hello:

This series was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Wed, 13 Nov 2024 02:27:50 +0900 you wrote:
> An RFC was sent last weekend to kick-off the discussion of the
> introduction of CAN XL: [1] for the kernel side and [2] for the
> iproute2 interface. While the series received some positive feedback,
> it is far from completion. Some work is still needed to:
> 
>   - adjust the nesting of the IFLA_CAN_XL_DATA_BITTIMING_CONST in the
>     netlink interface
> 
> [...]

Here is the summary with links:
  - [iproute2-next,v1,1/6] iplink_can: remove unused FILE *f parameter in three functions
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=df72757907f3
  - [iproute2-next,v1,2/6] iplink_can: reduce the visibility of tdc in can_parse_opt()
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=3bd5fb4d57aa
  - [iproute2-next,v1,3/6] iplink_can: remove newline at the end of invarg()'s messages
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=9b1f33d5a46d
  - [iproute2-next,v1,4/6] iplink_can: use invarg() instead of fprintf()
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=68aaea862838
  - [iproute2-next,v1,5/6] iplink_can: add struct can_tdc
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=aac087a0108b
  - [iproute2-next,v1,6/6] iplink_can: rename dbt into fd_dbt in can_parse_opt()
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=3f2ab9d6070e

You are awesome, thank you!