mbox series

[v3,net-next,0/9] af_unix: Set skb drop reason in every kfree_skb() path.

Message ID 20250116053441.5758-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series af_unix: Set skb drop reason in every kfree_skb() path. | expand

Message

Kuniyuki Iwashima Jan. 16, 2025, 5:34 a.m. UTC
There is a potential user for skb drop reason for AF_UNIX.

This series replaces some kfree_skb() in connect() and
sendmsg() paths and sets skb drop reason for the rest of
kfree_skb() in AF_UNIX.

Link: https://lore.kernel.org/netdev/CAAf2ycmZHti95WaBR3s+L5Epm1q7sXmvZ-EqCK=-oZj=45tOwQ@mail.gmail.com/


Changes:
  v3:
    * Drop skb drop reason patches for connect() and sendmsg()
    * Restore patch 8
    * Add patch 9 replacing kfree_skb() with consume_skb() in connect()
      and sendmsg()

  v2: https://lore.kernel.org/netdev/20250112040810.14145-1-kuniyu@amazon.com/
    * Drop the old patch 6 to silence false-positive uninit warning

  v1: https://lore.kernel.org/netdev/20250110092641.85905-1-kuniyu@amazon.com/


Kuniyuki Iwashima (9):
  net: dropreason: Gather SOCKET_ drop reasons.
  af_unix: Set drop reason in unix_release_sock().
  af_unix: Set drop reason in unix_sock_destructor().
  af_unix: Set drop reason in __unix_gc().
  af_unix: Set drop reason in manage_oob().
  af_unix: Set drop reason in unix_stream_read_skb().
  af_unix: Set drop reason in unix_dgram_disconnected().
  af_unix: Reuse out_pipe label in unix_stream_sendmsg().
  af_unix: Use consume_skb() in connect() and sendmsg().

 include/net/dropreason-core.h | 28 +++++++++++----
 net/unix/af_unix.c            | 67 +++++++++++++++++------------------
 net/unix/garbage.c            |  2 +-
 3 files changed, 55 insertions(+), 42 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 20, 2025, 7:50 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 16 Jan 2025 14:34:33 +0900 you wrote:
> There is a potential user for skb drop reason for AF_UNIX.
> 
> This series replaces some kfree_skb() in connect() and
> sendmsg() paths and sets skb drop reason for the rest of
> kfree_skb() in AF_UNIX.
> 
> Link: https://lore.kernel.org/netdev/CAAf2ycmZHti95WaBR3s+L5Epm1q7sXmvZ-EqCK=-oZj=45tOwQ@mail.gmail.com/
> 
> [...]

Here is the summary with links:
  - [v3,net-next,1/9] net: dropreason: Gather SOCKET_ drop reasons.
    https://git.kernel.org/netdev/net-next/c/454d402481d4
  - [v3,net-next,2/9] af_unix: Set drop reason in unix_release_sock().
    https://git.kernel.org/netdev/net-next/c/c32f0bd7d483
  - [v3,net-next,3/9] af_unix: Set drop reason in unix_sock_destructor().
    https://git.kernel.org/netdev/net-next/c/4d0446b7a214
  - [v3,net-next,4/9] af_unix: Set drop reason in __unix_gc().
    https://git.kernel.org/netdev/net-next/c/c49a157c33c4
  - [v3,net-next,5/9] af_unix: Set drop reason in manage_oob().
    https://git.kernel.org/netdev/net-next/c/533643b091dd
  - [v3,net-next,6/9] af_unix: Set drop reason in unix_stream_read_skb().
    https://git.kernel.org/netdev/net-next/c/bace4b468049
  - [v3,net-next,7/9] af_unix: Set drop reason in unix_dgram_disconnected().
    https://git.kernel.org/netdev/net-next/c/b3e365bbf4f4
  - [v3,net-next,8/9] af_unix: Reuse out_pipe label in unix_stream_sendmsg().
    https://git.kernel.org/netdev/net-next/c/3b2d40dc13c2
  - [v3,net-next,9/9] af_unix: Use consume_skb() in connect() and sendmsg().
    https://git.kernel.org/netdev/net-next/c/085e6cba85ca

You are awesome, thank you!