mbox series

[v2,net-next,0/8] fib: rules: Convert RTM_NEWRULE and RTM_DELRULE to per-netns RTNL.

Message ID 20250207072502.87775-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series fib: rules: Convert RTM_NEWRULE and RTM_DELRULE to per-netns RTNL. | expand

Message

Kuniyuki Iwashima Feb. 7, 2025, 7:24 a.m. UTC
Patch 1 ~ 2 are small cleanup, and patch 3 ~ 8 make fib_nl_newrule()
and fib_nl_delrule() hold per-netns RTNL.


Changes:
  v2:
    * Add patch 4 & 5
    * Don't use !!extack to check if RTNL is held

  v1: https://lore.kernel.org/netdev/20250206084629.16602-1-kuniyu@amazon.com/


Kuniyuki Iwashima (8):
  net: fib_rules: Don't check net in rule_exists() and rule_find().
  net: fib_rules: Pass net to fib_nl2rule() instead of skb.
  net: fib_rules: Split fib_nl2rule().
  ip: fib_rules: Fetch net from fib_rule in fib[46]_rule_configure().
  net: fib_rules: Factorise fib_newrule() and fib_delrule().
  net: fib_rules: Convert RTM_NEWRULE to per-netns RTNL.
  net: fib_rules: Add error_free label in fib_delrule().
  net: fib_rules: Convert RTM_DELRULE to per-netns RTNL.

 drivers/net/vrf.c       |   6 +-
 include/net/fib_rules.h |   8 +--
 net/core/fib_rules.c    | 151 ++++++++++++++++++++++++++--------------
 net/ipv4/fib_rules.c    |   4 +-
 net/ipv6/fib6_rules.c   |   4 +-
 5 files changed, 110 insertions(+), 63 deletions(-)

Comments

Eric Dumazet Feb. 7, 2025, 8:37 a.m. UTC | #1
On Fri, Feb 7, 2025 at 8:25 AM Kuniyuki Iwashima <kuniyu@amazon.com> wrote:
>
> Patch 1 ~ 2 are small cleanup, and patch 3 ~ 8 make fib_nl_newrule()
> and fib_nl_delrule() hold per-netns RTNL.
>
>
> Changes:
>   v2:
>     * Add patch 4 & 5
>     * Don't use !!extack to check if RTNL is held
>
>   v1: https://lore.kernel.org/netdev/20250206084629.16602-1-kuniyu@amazon.com/
>

Reviewed-by: Eric Dumazet <edumazet@google.com>
Ido Schimmel Feb. 7, 2025, 10:20 a.m. UTC | #2
On Fri, Feb 07, 2025 at 04:24:54PM +0900, Kuniyuki Iwashima wrote:
> Patch 1 ~ 2 are small cleanup, and patch 3 ~ 8 make fib_nl_newrule()
> and fib_nl_delrule() hold per-netns RTNL.

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
patchwork-bot+netdevbpf@kernel.org Feb. 11, 2025, 3:30 a.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 7 Feb 2025 16:24:54 +0900 you wrote:
> Patch 1 ~ 2 are small cleanup, and patch 3 ~ 8 make fib_nl_newrule()
> and fib_nl_delrule() hold per-netns RTNL.
> 
> 
> Changes:
>   v2:
>     * Add patch 4 & 5
>     * Don't use !!extack to check if RTNL is held
> 
> [...]

Here is the summary with links:
  - [v2,net-next,1/8] net: fib_rules: Don't check net in rule_exists() and rule_find().
    https://git.kernel.org/netdev/net-next/c/7b7df666a233
  - [v2,net-next,2/8] net: fib_rules: Pass net to fib_nl2rule() instead of skb.
    https://git.kernel.org/netdev/net-next/c/a9ffd24b5528
  - [v2,net-next,3/8] net: fib_rules: Split fib_nl2rule().
    https://git.kernel.org/netdev/net-next/c/8b498773c861
  - [v2,net-next,4/8] ip: fib_rules: Fetch net from fib_rule in fib[46]_rule_configure().
    https://git.kernel.org/netdev/net-next/c/5a1ccffd30a0
  - [v2,net-next,5/8] net: fib_rules: Factorise fib_newrule() and fib_delrule().
    https://git.kernel.org/netdev/net-next/c/a0596c2c63fc
  - [v2,net-next,6/8] net: fib_rules: Convert RTM_NEWRULE to per-netns RTNL.
    https://git.kernel.org/netdev/net-next/c/98d3a6f681ca
  - [v2,net-next,7/8] net: fib_rules: Add error_free label in fib_delrule().
    https://git.kernel.org/netdev/net-next/c/1cf770da0112
  - [v2,net-next,8/8] net: fib_rules: Convert RTM_DELRULE to per-netns RTNL.
    https://git.kernel.org/netdev/net-next/c/88b9cfca8d77

You are awesome, thank you!