mbox series

[net-next,0/5] eth: fbnic: report software queue stats

Message ID 20250211181356.580800-1-kuba@kernel.org (mailing list archive)
Headers show
Series eth: fbnic: report software queue stats | expand

Message

Jakub Kicinski Feb. 11, 2025, 6:13 p.m. UTC
Fill in typical software queue stats.

  # ./pyynl/cli.py --spec netlink/specs/netdev.yaml --dump qstats-get 
  [{'ifindex': 2,
    'rx-alloc-fail': 0,
    'rx-bytes': 398064076,
    'rx-csum-complete': 271,
    'rx-csum-none': 0,
    'rx-packets': 276044,
    'tx-bytes': 7223770,
    'tx-needs-csum': 28148,
    'tx-packets': 28449,
    'tx-stop': 0,
    'tx-wake': 0}]

Note that we don't collect csum-unnecessary, just the uncommon
cases (and unnecessary is all the rest of the packets). There
is no programatic use for these stats AFAIK, just manual debug.

Jakub Kicinski (5):
  net: report csum_complete via qstats
  eth: fbnic: wrap tx queue stats in a struct
  eth: fbnic: report software Rx queue stats
  eth: fbnic: report software Tx queue stats
  eth: fbnic: re-sort the objects in the Makefile

 drivers/net/ethernet/meta/fbnic/Makefile      |  3 +-
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.h  | 16 +++-
 include/net/netdev_queues.h                   |  1 +
 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   |  8 +-
 .../net/ethernet/meta/fbnic/fbnic_netdev.c    | 22 +++++-
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  | 74 +++++++++++++++----
 net/core/netdev-genl.c                        |  1 +
 7 files changed, 102 insertions(+), 23 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 13, 2025, 12:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 11 Feb 2025 10:13:51 -0800 you wrote:
> Fill in typical software queue stats.
> 
>   # ./pyynl/cli.py --spec netlink/specs/netdev.yaml --dump qstats-get
>   [{'ifindex': 2,
>     'rx-alloc-fail': 0,
>     'rx-bytes': 398064076,
>     'rx-csum-complete': 271,
>     'rx-csum-none': 0,
>     'rx-packets': 276044,
>     'tx-bytes': 7223770,
>     'tx-needs-csum': 28148,
>     'tx-packets': 28449,
>     'tx-stop': 0,
>     'tx-wake': 0}]
> 
> [...]

Here is the summary with links:
  - [net-next,1/5] net: report csum_complete via qstats
    https://git.kernel.org/netdev/net-next/c/34eea78a1112
  - [net-next,2/5] eth: fbnic: wrap tx queue stats in a struct
    (no matching commit)
  - [net-next,3/5] eth: fbnic: report software Rx queue stats
    (no matching commit)
  - [net-next,4/5] eth: fbnic: report software Tx queue stats
    (no matching commit)
  - [net-next,5/5] eth: fbnic: re-sort the objects in the Makefile
    https://git.kernel.org/netdev/net-next/c/0ec023282a9d

You are awesome, thank you!