[net,0/2] net: make memory provider install / close paths more common

Message

Jakub Kicinski March 31, 2025, 7:42 p.m. UTC

We seem to be fixing bugs in config path for devmem which also exist
in the io_uring ZC path. Let's try to make the two paths more common,
otherwise this is bound to keep happening.

Found by code inspection and compile tested only.

Jakub Kicinski (2):
  net: move mp dev config validation to __net_mp_open_rxq()
  net: avoid false positive warnings in __net_mp_close_rxq()

 include/net/page_pool/memory_provider.h |  6 +++
 net/core/devmem.c                       | 64 ++++++------------------
 net/core/netdev-genl.c                  |  6 ---
 net/core/netdev_rx_queue.c              | 66 ++++++++++++++++++-------
 4 files changed, 69 insertions(+), 73 deletions(-)

Comments

Taehee Yoo April 2, 2025, 3:35 p.m. UTC | #1

On Tue, Apr 1, 2025 at 4:42 AM Jakub Kicinski <[e-mail]> wrote:
>

Hi Jakub,
Thanks a lot for this fix!

> We seem to be fixing bugs in config path for devmem which also exist
> in the io_uring ZC path. Let's try to make the two paths more common,
> otherwise this is bound to keep happening.
>
> Found by code inspection and compile tested only.

I tested this patchset with my RFC[1].
This works well, and I can't see any splat by kmemleak, lockdep, etc.

[1]https://lore.kernel.org/netdev/[e-mail]/

Thanks a lot!
Taehee Yoo

>
> Jakub Kicinski (2):
>   net: move mp dev config validation to __net_mp_open_rxq()
>   net: avoid false positive warnings in __net_mp_close_rxq()
>
>  include/net/page_pool/memory_provider.h |  6 +++
>  net/core/devmem.c                       | 64 ++++++------------------
>  net/core/netdev-genl.c                  |  6 ---
>  net/core/netdev_rx_queue.c              | 66 ++++++++++++++++++-------
>  4 files changed, 69 insertions(+), 73 deletions(-)
>
> --
> 2.49.0
>