[net-next,0/3] Convert mvneta to phylink supported_interfaces

Message

Russell King (Oracle) Oct. 27, 2021, 9:03 a.m. UTC

Hi,

This patch series converts mvneta to use phylinks supported_interfaces
bitmap to simplify the validate() implementation. The patches:

1) Add the supported interface modes the supported_interfaces bitmap.
2) Removes the checks for the interface type being supported from
   the validate callback
3) Removes the now unnecessary checks and call to
   phylink_helper_basex_speed() to support switching between
   1000base-X and 2500base-X for SFPs

(3) becomes possible because when asking the MAC for its complete
support, we walk all supported interfaces which will include 1000base-X
and 2500base-X only if the comphy is present.

 drivers/net/ethernet/marvell/mvneta.c | 48 ++++++++++++++++++++++-------------
 1 file changed, 30 insertions(+), 18 deletions(-)

Comments

[e-mail] Oct. 27, 2021, 2:40 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Wed, 27 Oct 2021 10:03:11 +0100 you wrote:
> Hi,
> 
> This patch series converts mvneta to use phylinks supported_interfaces
> bitmap to simplify the validate() implementation. The patches:
> 
> 1) Add the supported interface modes the supported_interfaces bitmap.
> 2) Removes the checks for the interface type being supported from
>    the validate callback
> 3) Removes the now unnecessary checks and call to
>    phylink_helper_basex_speed() to support switching between
>    1000base-X and 2500base-X for SFPs
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net: mvneta: populate supported_interfaces member
    https://git.kernel.org/netdev/net-next/c/fdedb695e6a8
  - [net-next,2/3] net: mvneta: remove interface checks in mvneta_validate()
    https://git.kernel.org/netdev/net-next/c/d9ca72807ecb
  - [net-next,3/3] net: mvneta: drop use of phylink_helper_basex_speed()
    https://git.kernel.org/netdev/net-next/c/099cbfa286ab

You are awesome, thank you!