[net-next,0/3] Convert mvpp2 to phylink supported_interfaces

Message

Russell King (Oracle) Oct. 27, 2021, 9:48 a.m. UTC

Hi,

This patch series converts mvpp2 to use phylinks supported_interfaces
bitmap to simplify the validate() implementation. The patches:

1) Add the supported interface modes the supported_interfaces bitmap.
2) Removes the checks for the interface type being supported from
   the validate callback
3) Removes the now unnecessary checks and call to
   phylink_helper_basex_speed() to support switching between
   1000base-X and 2500base-X for SFPs
4) Cleans up the resulting validate() code.

(3) becomes possible because when asking the MAC for its complete
support, we walk all supported interfaces which will include 1000base-X
and 2500base-X only if the comphy is present.

 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 95 +++++++++++++------------
 1 file changed, 50 insertions(+), 45 deletions(-)

Comments

[e-mail] Oct. 28, 2021, 12:20 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Wed, 27 Oct 2021 10:48:38 +0100 you wrote:
> Hi,
> 
> This patch series converts mvpp2 to use phylinks supported_interfaces
> bitmap to simplify the validate() implementation. The patches:
> 
> 1) Add the supported interface modes the supported_interfaces bitmap.
> 2) Removes the checks for the interface type being supported from
>    the validate callback
> 3) Removes the now unnecessary checks and call to
>    phylink_helper_basex_speed() to support switching between
>    1000base-X and 2500base-X for SFPs
> 4) Cleans up the resulting validate() code.
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] net: mvpp2: populate supported_interfaces member
    https://git.kernel.org/netdev/net-next/c/8498e17ed4c5
  - [net-next,2/4] net: mvpp2: remove interface checks in mvpp2_phylink_validate()
    https://git.kernel.org/netdev/net-next/c/6c0c4b7ac06f
  - [net-next,3/4] net: mvpp2: drop use of phylink_helper_basex_speed()
    https://git.kernel.org/netdev/net-next/c/76947a635874
  - [net-next,4/4] net: mvpp2: clean up mvpp2_phylink_validate()
    https://git.kernel.org/netdev/net-next/c/b63f1117aefc

You are awesome, thank you!