From patchwork Tue Jun 13 14:36:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Russell King (Oracle)" X-Patchwork-Id: 13278906 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7494E23DB for ; Tue, 13 Jun 2023 14:37:43 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D78DA19B2 for ; Tue, 13 Jun 2023 07:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KRnxY7Re/nGiYJmsN7Hoy8JfAM4oj0NdO4GrYafwkB8=; b=fYVrgFR2pdfsXiaa62vFsBaUbn XfvcRgsqPNkFg5/V6fmDe2K54iHRTFjgnV9GGmNJ3aGoxaJM4jd/nOm3c6j4q2/GfHjLwWlx78gmn pchobLrpQbO+M5oA6wWdBjIJdXy5SmZjwfnngZXMIWcmgLvrYGBw8gp5SDxlSNfzqPN4eYmabc8VT RPeWuQp04KMZI9UeG4uhXCh0YOzlUqYHl9MdPlz7XIPO2H3nxbCWRCNIqYuEbRz9bYaAELekmz/Mt v4FBXsyh5sIPc3z+OPZX4NIMPc3vm+USUN7f5ULia3tZKnfnaBBSiASxaLl3gPA8uXdmgLBHLIAc4 4EIlVGDw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43188) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q958r-0007Pd-1g; Tue, 13 Jun 2023 15:37:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q958i-00066D-Vl; Tue, 13 Jun 2023 15:36:56 +0100 Date: Tue, 13 Jun 2023 15:36:56 +0100 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexander Couzens , AngeloGioacchino Del Regno , Cc: Claudiu Beznea , Daniel Golle , Daniel Machon , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , Horatiu Vultur , Ioana Ciornei , Jakub Kicinski , Jose Abreu , Landen Chao , Lars Povlsen , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Madalin Bucur , Marcin Wojtas , Matthias Brugger , Michal Simek , netdev@vger.kernel.org, Nicolas Ferre , Paolo Abeni , Radhey Shyam Pandey , Sean Anderson , Sean Wang , Steen Hegelund , Taras Chornyi , Thomas Petazzoni , UNGLinuxDriver@microchip.com, Vladimir Oltean Subject: [PATCH RFC 0/15] Add and use helper for PCS negotiation modes Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Patchwork-State: RFC Hi, Earlier this month, I proposed a helper for deciding whether a PCS should use inband negotiation modes or not. There was some discussion around this topic, and I believe there was no disagreement about providing the helper. The initial discussion can be found at: https://lore.kernel.org/r/ZGIkGmyL8yL1q1zp@shell.armlinux.org.uk Subsequently, I posted a RFC series back in May: https://lore.kernel.org/r/ZGzhvePzPjJ0v2En@shell.armlinux.org.uk that added a helper, phylink_pcs_neg_mode() which PCS drivers could use to parse the state, and updated a bunch of drivers to use it. I got a couple of bits of feedback to it, including some ACKs. However, I've decided to take this slightly further and change the "mode" parameter to both the pcs_config() and pcs_link_up() methods when a PCS driver opts in to this (by setting "neg_mode" in the phylink_pcs structure.) If this is not set, we default to the old behaviour. That said, this series converts all the PCS implementations I can find currently in net-next. Doing this has the added benefit that the negotiation mode parameter is also available to the pcs_link_up() function, which can now know whether inband negotiation was in fact enabled or not at pcs_config() time. Consequently, because the driver implementations have changed, I've dropped the acks I received previously. I've build-tested this, but I can't guarantee having build-tested every change. drivers/net/dsa/qca/qca8k-8xxx.c | 13 ++- drivers/net/dsa/sja1105/sja1105_main.c | 14 ++- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 7 +- drivers/net/ethernet/marvell/mvneta.c | 7 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 +-- .../net/ethernet/marvell/prestera/prestera_main.c | 11 +-- .../net/ethernet/microchip/lan966x/lan966x_main.c | 1 + .../ethernet/microchip/lan966x/lan966x_phylink.c | 7 +- .../net/ethernet/microchip/sparx5/sparx5_main.c | 1 + .../net/ethernet/microchip/sparx5/sparx5_phylink.c | 8 +- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +- drivers/net/pcs/pcs-lynx.c | 48 +++++---- drivers/net/pcs/pcs-mtk-lynxi.c | 39 +++----- drivers/net/pcs/pcs-xpcs.c | 43 ++++---- drivers/net/phy/phylink.c | 59 +++++++---- include/linux/pcs/pcs-xpcs.h | 4 +- include/linux/phylink.h | 109 +++++++++++++++++++-- 17 files changed, 253 insertions(+), 138 deletions(-)