mbox series

[net-next,v2,0/3] net: phylink: simplify SFP PHY attachment

Message ID Zxj8_clRmDA_G7uH@shell.armlinux.org.uk (mailing list archive)
Headers show
Series net: phylink: simplify SFP PHY attachment | expand

Message

Russell King (Oracle) Oct. 23, 2024, 1:41 p.m. UTC 
Hi,

These two patches simplify how we attach SFP PHYs.

The first patch notices that at the two sites where we call
sfp_select_interface(), if that fails, we always print the same error.
Move this into its own function.

The second patch adds an additional level of validation, checking that
the returned interface is one that is supported by the MAC/PCS.

The last patch simplifies how SFP PHYs are attached, reducing the
number of times that we do validation in this path.

 drivers/net/phy/phylink.c | 83 ++++++++++++++++++++++++-----------------------
 1 file changed, 42 insertions(+), 41 deletions(-)

Changes since v1:
 - Fixed build warning.
 - Added r-b/t-b from Maxime.

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 29, 2024, 7 p.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 23 Oct 2024 14:41:17 +0100 you wrote:
> Hi,
> 
> These two patches simplify how we attach SFP PHYs.
> 
> The first patch notices that at the two sites where we call
> sfp_select_interface(), if that fails, we always print the same error.
> Move this into its own function.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/3] net: phylink: add common validation for sfp_select_interface()
    https://git.kernel.org/netdev/net-next/c/280ed44982ff
  - [net-next,v2,2/3] net: phylink: validate sfp_select_interface() returned interface
    https://git.kernel.org/netdev/net-next/c/41caa7e81b97
  - [net-next,v2,3/3] net: phylink: simplify how SFP PHYs are attached
    https://git.kernel.org/netdev/net-next/c/25391e82ffe2

You are awesome, thank you!