[net,v3,0/2] dpaa_eth: buffer layout fixes

Message

Camelia Alexandra Groza Nov. 2, 2020, 6:34 p.m. UTC

The patches are related to the software workaround for the A050385 erratum.
The first patch ensures optimal buffer usage for non-erratum scenarios. The
second patch fixes a currently inconsequential discrepancy between the
FMan and Ethernet drivers.

Changes in v3:
- refactor defines for clarity in 1/2
- add more details on the user impact in 1/2
- remove unnecessary inline identifier in 2/2

Changes in v2:
- make the returned value for TX ports explicit in 2/2
- simplify the buf_layout reference in 2/2

Camelia Groza (2):
  dpaa_eth: update the buffer layout for non-A050385 erratum scenarios
  dpaa_eth: fix the RX headroom size alignment

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 28 +++++++++++++++++---------
 1 file changed, 18 insertions(+), 10 deletions(-)

--
1.9.1

Comments

Madalin Bucur (OSS) Nov. 3, 2020, 12:17 p.m. UTC | #1

> -----Original Message-----
> From: Camelia Groza <[e-mail]>
> Sent: 02 November 2020 20:35
> To: [e-mail]; Madalin Bucur (OSS)
> <[e-mail]>; [e-mail]; [e-mail]
> Cc: [e-mail]; Camelia Alexandra Groza <[e-mail]>
> Subject: [PATCH net v3 0/2] dpaa_eth: buffer layout fixes
> 
> The patches are related to the software workaround for the A050385 erratum.
> The first patch ensures optimal buffer usage for non-erratum scenarios.
> The
> second patch fixes a currently inconsequential discrepancy between the
> FMan and Ethernet drivers.
> 
> Changes in v3:
> - refactor defines for clarity in 1/2
> - add more details on the user impact in 1/2
> - remove unnecessary inline identifier in 2/2
> 
> Changes in v2:
> - make the returned value for TX ports explicit in 2/2
> - simplify the buf_layout reference in 2/2
> 
> Camelia Groza (2):
>   dpaa_eth: update the buffer layout for non-A050385 erratum scenarios
>   dpaa_eth: fix the RX headroom size alignment
> 
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 28 +++++++++++++++++----
> -----
>  1 file changed, 18 insertions(+), 10 deletions(-)
> 
> --
> 1.9.1

For the series,

Acked-by: Madalin Bucur <[e-mail]>

Camelia Alexandra Groza Nov. 3, 2020, 4:37 p.m. UTC | #2

> -----Original Message-----
> From: Camelia Groza <[e-mail]>
> Sent: Monday, November 2, 2020 20:35
> To: [e-mail]; Madalin Bucur (OSS)
> <[e-mail]>; [e-mail]; [e-mail]
> Cc: [e-mail]; Camelia Alexandra Groza
> <[e-mail]>
> Subject: [PATCH net v3 0/2] dpaa_eth: buffer layout fixes
> 
> The patches are related to the software workaround for the A050385
> erratum.
> The first patch ensures optimal buffer usage for non-erratum scenarios. The
> second patch fixes a currently inconsequential discrepancy between the
> FMan and Ethernet drivers.
> 

Jakub, when are you planning the next merger of net into net-next? I have a patch set for net-next depending on this one.

Thanks!
Camelia

Jakub Kicinski Nov. 3, 2020, 6:42 p.m. UTC | #3

On Tue, 3 Nov 2020 16:37:26 +0000 Camelia Alexandra Groza wrote:
> > Subject: [PATCH net v3 0/2] dpaa_eth: buffer layout fixes
> > 
> > The patches are related to the software workaround for the A050385
> > erratum.
> > The first patch ensures optimal buffer usage for non-erratum scenarios. The
> > second patch fixes a currently inconsequential discrepancy between the
> > FMan and Ethernet drivers.

Hm, looks like the bot didn't reply, these are applied to net, as you
probably noticed.
 
> Jakub, when are you planning the next merger of net into net-next? I
> have a patch set for net-next depending on this one.

Thursday afternoon PST, or Friday. Depends on when Linus pulls from net.