[net-next,v3,00/13] mptcp: improve multiple xmit streams support

Message

Paolo Abeni Nov. 16, 2020, 9:48 a.m. UTC

This series improves MPTCP handling of multiple concurrent
xmit streams.

The to-be-transmitted data is enqueued to a subflow only when
the send window is open, keeping the subflows xmit queue shorter
and allowing for faster switch-over.

The above requires a more accurate msk socket state tracking
and some additional infrastructure to allow pushing the data
pending in the msk xmit queue as soon as the MPTCP's send window
opens (patches 6-10).

As a side effect, the MPTCP socket could enqueue data to subflows
after close() time - to completely spooling the data sitting in the 
msk xmit queue. Dealing with the requires some infrastructure and 
core TCP changes (patches 1-5)

Finally, patches 11-12 introduce a more accurate tracking of the other
end's receive window.

Overall this refactor the MPTCP xmit path, without introducing
new features - the new code is covered by the existing self-tests.

v2 -> v3:
 - rebased,
 - fixed checkpatch issue in patch 1/13
 - fixed some state tracking issues in patch 8/13

v1 -> v2:
 - this is just a report, to cope with patchwork issues, no changes
   at all

Florian Westphal (2):
  mptcp: rework poll+nospace handling
  mptcp: keep track of advertised windows right edge

Paolo Abeni (11):
  tcp: factor out tcp_build_frag()
  mptcp: use tcp_build_frag()
  tcp: factor out __tcp_close() helper
  mptcp: introduce mptcp_schedule_work
  mptcp: reduce the arguments of mptcp_sendmsg_frag
  mptcp: add accounting for pending data
  mptcp: introduce MPTCP snd_nxt
  mptcp: refactor shutdown and close
  mptcp: move page frag allocation in mptcp_sendmsg()
  mptcp: try to push pending data on snd una updates
  mptcp: send explicit ack on delayed ack_seq incr

 include/net/tcp.h      |   4 +
 net/ipv4/tcp.c         | 128 +++---
 net/mptcp/options.c    |  30 +-
 net/mptcp/pm.c         |   3 +-
 net/mptcp/pm_netlink.c |   6 +-
 net/mptcp/protocol.c   | 998 ++++++++++++++++++++++++-----------------
 net/mptcp/protocol.h   |  72 ++-
 net/mptcp/subflow.c    |  33 +-
 8 files changed, 776 insertions(+), 498 deletions(-)

Comments

[e-mail] Nov. 16, 2020, 7:30 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Mon, 16 Nov 2020 10:48:01 +0100 you wrote:
> This series improves MPTCP handling of multiple concurrent
> xmit streams.
> 
> The to-be-transmitted data is enqueued to a subflow only when
> the send window is open, keeping the subflows xmit queue shorter
> and allowing for faster switch-over.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,01/13] tcp: factor out tcp_build_frag()
    https://git.kernel.org/netdev/net-next/c/b796d04bd014
  - [net-next,v3,02/13] mptcp: use tcp_build_frag()
    https://git.kernel.org/netdev/net-next/c/e2223995a287
  - [net-next,v3,03/13] tcp: factor out __tcp_close() helper
    https://git.kernel.org/netdev/net-next/c/77c3c9563752
  - [net-next,v3,04/13] mptcp: introduce mptcp_schedule_work
    https://git.kernel.org/netdev/net-next/c/ba8f48f7a4d7
  - [net-next,v3,05/13] mptcp: reduce the arguments of mptcp_sendmsg_frag
    https://git.kernel.org/netdev/net-next/c/caf971df01b8
  - [net-next,v3,06/13] mptcp: add accounting for pending data
    https://git.kernel.org/netdev/net-next/c/f0e6a4cf11f1
  - [net-next,v3,07/13] mptcp: introduce MPTCP snd_nxt
    https://git.kernel.org/netdev/net-next/c/eaa2ffabfc35
  - [net-next,v3,08/13] mptcp: refactor shutdown and close
    https://git.kernel.org/netdev/net-next/c/e16163b6e2b7
  - [net-next,v3,09/13] mptcp: move page frag allocation in mptcp_sendmsg()
    https://git.kernel.org/netdev/net-next/c/d9ca1de8c0cd
  - [net-next,v3,10/13] mptcp: try to push pending data on snd una updates
    https://git.kernel.org/netdev/net-next/c/813e0a683d4c
  - [net-next,v3,11/13] mptcp: rework poll+nospace handling
    https://git.kernel.org/netdev/net-next/c/8edf08649eed
  - [net-next,v3,12/13] mptcp: keep track of advertised windows right edge
    https://git.kernel.org/netdev/net-next/c/6f8a612a33e4
  - [net-next,v3,13/13] mptcp: send explicit ack on delayed ack_seq incr
    https://git.kernel.org/netdev/net-next/c/7ed90803a213

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html