[bpf-next,0/2] add xdp_build_skb_from_frame utility routine

Message

Lorenzo Bianconi Dec. 16, 2020, 6:38 p.m. UTC

Introduce __xdp_build_skb_from_frame and xdp_build_skb_from_frame routines to
build the skb from a xdp_frame. Respect to __xdp_build_skb_from_frame,
xdp_build_skb_from_frame will allocate the skb object.
Rely on __xdp_build_skb_from_frame/xdp_build_skb_from_frame in cpumap and veth
code.

Lorenzo Bianconi (2):
  net: xdp: introduce __xdp_build_skb_from_frame utility routine
  net: xdp: introduce xdp_build_skb_from_frame utility routine

 drivers/net/veth.c  | 18 +++-----------
 include/net/xdp.h   |  5 ++++
 kernel/bpf/cpumap.c | 45 +---------------------------------
 net/core/xdp.c      | 59 +++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 68 insertions(+), 59 deletions(-)

Comments

Lorenzo Bianconi Jan. 12, 2021, 4:08 p.m. UTC | #1

> Introduce __xdp_build_skb_from_frame and xdp_build_skb_from_frame routines to
> build the skb from a xdp_frame. Respect to __xdp_build_skb_from_frame,
> xdp_build_skb_from_frame will allocate the skb object.
> Rely on __xdp_build_skb_from_frame/xdp_build_skb_from_frame in cpumap and veth
> code.

Hi Daniel/Alexei,

since this series is marked as "archived" in patchwork, do I need to resubmit it?

Regards,
Lorenzo

> 
> Lorenzo Bianconi (2):
>   net: xdp: introduce __xdp_build_skb_from_frame utility routine
>   net: xdp: introduce xdp_build_skb_from_frame utility routine
> 
>  drivers/net/veth.c  | 18 +++-----------
>  include/net/xdp.h   |  5 ++++
>  kernel/bpf/cpumap.c | 45 +---------------------------------
>  net/core/xdp.c      | 59 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 68 insertions(+), 59 deletions(-)
> 
> -- 
> 2.29.2
>

Daniel Borkmann Jan. 12, 2021, 4:50 p.m. UTC | #2

On 1/12/21 5:08 PM, Lorenzo Bianconi wrote:
>> Introduce __xdp_build_skb_from_frame and xdp_build_skb_from_frame routines to
>> build the skb from a xdp_frame. Respect to __xdp_build_skb_from_frame,
>> xdp_build_skb_from_frame will allocate the skb object.
>> Rely on __xdp_build_skb_from_frame/xdp_build_skb_from_frame in cpumap and veth
>> code.
> 
> since this series is marked as "archived" in patchwork, do I need to resubmit it?

Yes please do, afaik there was some minor feedback from Toshiaki which was not yet
addressed from your side.

Thanks,
Daniel

Lorenzo Bianconi Jan. 12, 2021, 4:53 p.m. UTC | #3

> On 1/12/21 5:08 PM, Lorenzo Bianconi wrote:
> > > Introduce __xdp_build_skb_from_frame and xdp_build_skb_from_frame routines to
> > > build the skb from a xdp_frame. Respect to __xdp_build_skb_from_frame,
> > > xdp_build_skb_from_frame will allocate the skb object.
> > > Rely on __xdp_build_skb_from_frame/xdp_build_skb_from_frame in cpumap and veth
> > > code.
> > 
> > since this series is marked as "archived" in patchwork, do I need to resubmit it?
> 
> Yes please do, afaik there was some minor feedback from Toshiaki which was not yet
> addressed from your side.

ack, will do.

Regards,
Lorenzo

> 
> Thanks,
> Daniel
>