[net,0/3] sctp: always send a chunk with the asoc that it belongs to

Message

Xin Long April 30, 2021, 6:15 p.m. UTC

Currently when processing a duplicate COOKIE-ECHO chunk, a new temp
asoc would be created, then it creates the chunks with the new asoc.
However, later on it uses the old asoc to send these chunks, which
has caused quite a few issues.

This patchset is to fix this and make sure that the COOKIE-ACK and
SHUTDOWN chunks are created with the same asoc that will be used to
send them out.

Xin Long (3):
  sctp: do asoc update earlier in sctp_sf_do_dupcook_a
  Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK"
  sctp: do asoc update earlier in sctp_sf_do_dupcook_b

 include/net/sctp/command.h |  1 -
 net/sctp/sm_sideeffect.c   | 26 ------------------------
 net/sctp/sm_statefuns.c    | 50 ++++++++++++++++++++++++++++++++++++----------
 3 files changed, 39 insertions(+), 38 deletions(-)

Comments

Marcelo Ricardo Leitner April 30, 2021, 6:22 p.m. UTC | #1

On Sat, May 01, 2021 at 02:15:54AM +0800, Xin Long wrote:
> Currently when processing a duplicate COOKIE-ECHO chunk, a new temp
> asoc would be created, then it creates the chunks with the new asoc.
> However, later on it uses the old asoc to send these chunks, which
> has caused quite a few issues.
> 
> This patchset is to fix this and make sure that the COOKIE-ACK and
> SHUTDOWN chunks are created with the same asoc that will be used to
> send them out.
> 
> Xin Long (3):
>   sctp: do asoc update earlier in sctp_sf_do_dupcook_a
>   Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK"
>   sctp: do asoc update earlier in sctp_sf_do_dupcook_b

Thanks folks.
Acked-by: Marcelo Ricardo Leitner <[e-mail]>