| Message ID | cover.1619812899.git.lucien.xin@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | sctp: always send a chunk with the asoc that it belongs to | expand |
Hello: This series was applied to netdev/net.git (refs/heads/master): On Sat, 1 May 2021 04:02:57 +0800 you wrote: > Currently when processing a duplicate COOKIE-ECHO chunk, a new temp > asoc would be created, then it creates the chunks with the new asoc. > However, later on it uses the old asoc to send these chunks, which > has caused quite a few issues. > > This patchset is to fix this and make sure that the COOKIE-ACK and > SHUTDOWN chunks are created with the same asoc that will be used to > send them out. > > [...] Here is the summary with links: - [PATCHv2,net,1/3] sctp: do asoc update earlier in sctp_sf_do_dupcook_a https://git.kernel.org/netdev/net/c/35b4f24415c8 - [PATCHv2,net,2/3] Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK" https://git.kernel.org/netdev/net/c/7e9269a5acec - [PATCHv2,net,3/3] sctp: do asoc update earlier in sctp_sf_do_dupcook_b https://git.kernel.org/netdev/net/c/51eac7f2f06b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On Fri, 30 Apr 2021, Xin Long wrote: > Currently when processing a duplicate COOKIE-ECHO chunk, a new temp > asoc would be created, then it creates the chunks with the new asoc. > However, later on it uses the old asoc to send these chunks, which > has caused quite a few issues. > > This patchset is to fix this and make sure that the COOKIE-ACK and > SHUTDOWN chunks are created with the same asoc that will be used to > send them out. Again, much thanks for looking into this. Patches 1 and 3 are almost the same as my patch, which as I mentioned I've been testing on and off for the past couple of weeks, and haven't found any problems. (Then again, I didn't find any problems last time either.) I think 145cb2f7177d ("sctp: Fix bundling of SHUTDOWN with COOKIE-ACK") should not be reverted (I'll reply to the patch). 12dfd78e3a74 ("sctp: Fix SHUTDOWN CTSN Ack in the peer restart case") should be reverted. With association update no longer a side effect, we can get CTSN normally from current assoc, since it has been updated before sctp_make_shutdown(). > > v1->v2: > - see Patch 3/3. > > Xin Long (3): > sctp: do asoc update earlier in sctp_sf_do_dupcook_a > Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK" > sctp: do asoc update earlier in sctp_sf_do_dupcook_b > > include/net/sctp/command.h | 1 - > net/sctp/sm_sideeffect.c | 26 ------------------------ > net/sctp/sm_statefuns.c | 50 ++++++++++++++++++++++++++++++++++++---------- > 3 files changed, 39 insertions(+), 38 deletions(-) > > -- > 2.1.0
On Sat, May 1, 2021 at 12:54 PM Leppanen, Jere (Nokia - FI/Espoo) <jere.leppanen@nokia.com> wrote: > > On Fri, 30 Apr 2021, Xin Long wrote: > > > Currently when processing a duplicate COOKIE-ECHO chunk, a new temp > > asoc would be created, then it creates the chunks with the new asoc. > > However, later on it uses the old asoc to send these chunks, which > > has caused quite a few issues. > > > > This patchset is to fix this and make sure that the COOKIE-ACK and > > SHUTDOWN chunks are created with the same asoc that will be used to > > send them out. > > Again, much thanks for looking into this. Patches 1 and 3 are > almost the same as my patch, which as I mentioned I've been > testing on and off for the past couple of weeks, and haven't > found any problems. (Then again, I didn't find any problems last > time either.) > > I think 145cb2f7177d ("sctp: Fix bundling of SHUTDOWN with > COOKIE-ACK") should not be reverted (I'll reply to the patch). > > 12dfd78e3a74 ("sctp: Fix SHUTDOWN CTSN Ack in the peer restart > case") should be reverted. With association update no longer a > side effect, we can get CTSN normally from current assoc, since > it has been updated before sctp_make_shutdown(). Good catch, didn't notice this one. Will do it. Thanks. > > > > > v1->v2: > > - see Patch 3/3. > > > > Xin Long (3): > > sctp: do asoc update earlier in sctp_sf_do_dupcook_a > > Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK" > > sctp: do asoc update earlier in sctp_sf_do_dupcook_b > > > > include/net/sctp/command.h | 1 - > > net/sctp/sm_sideeffect.c | 26 ------------------------ > > net/sctp/sm_statefuns.c | 50 ++++++++++++++++++++++++++++++++++++---------- > > 3 files changed, 39 insertions(+), 38 deletions(-) > > > > -- > > 2.1.0