[PATCHv2,net,0/3] rtnetlink: a couple of fixes in linkmsg validation

Message

Xin Long May 31, 2023, 4:01 p.m. UTC

validate_linkmsg() was introduced to do linkmsg validation for existing
links. However, the new created links also need this linkmsg validation.

Add validate_linkmsg() check for link creating in Patch 1, and add more
tb checks into validate_linkmsg() in Patch 2 and 3.

v2:
- not improve the multiple times validating in patch 1, and will do it
  in net-next, as Jakub suggested.

Xin Long (3):
  rtnetlink: call validate_linkmsg in rtnl_create_link
  rtnetlink: move IFLA_GSO_ tb check to validate_linkmsg
  rtnetlink: add the missing IFLA_GRO_ tb check in validate_linkmsg

 net/core/rtnetlink.c | 54 +++++++++++++++++++++++++++++++-------------
 1 file changed, 38 insertions(+), 16 deletions(-)

Comments

[e-mail] June 1, 2023, 5:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Wed, 31 May 2023 12:01:41 -0400 you wrote:
> validate_linkmsg() was introduced to do linkmsg validation for existing
> links. However, the new created links also need this linkmsg validation.
> 
> Add validate_linkmsg() check for link creating in Patch 1, and add more
> tb checks into validate_linkmsg() in Patch 2 and 3.
> 
> v2:
> - not improve the multiple times validating in patch 1, and will do it
>   in net-next, as Jakub suggested.
> 
> [...]

Here is the summary with links:
  - [PATCHv2,net,1/3] rtnetlink: call validate_linkmsg in rtnl_create_link
    https://git.kernel.org/netdev/net/c/b0ad3c179059
  - [PATCHv2,net,2/3] rtnetlink: move IFLA_GSO_ tb check to validate_linkmsg
    https://git.kernel.org/netdev/net/c/fef5b228dd38
  - [PATCHv2,net,3/3] rtnetlink: add the missing IFLA_GRO_ tb check in validate_linkmsg
    https://git.kernel.org/netdev/net/c/65d6914e253f

You are awesome, thank you!