| Message ID | cover.1717088241.git.dcaratti@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: allow dissecting/matching tunnel control flags | expand |
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Thu, 30 May 2024 19:08:33 +0200 you wrote: > Ilya says: "for correct matching on decapsulated packets, we should match > on not only tunnel id and headers, but also on tunnel configuration flags > like TUNNEL_NO_CSUM and TUNNEL_DONT_FRAGMENT. This is done to distinguish > similar tunnels with slightly different configs. And it is important since > tunnel configuration is flow based, i.e. can be different for every packet, > even though the main tunnel port is the same." > > [...] Here is the summary with links: - [net-next,v4,1/2] flow_dissector: add support for tunnel control flags https://git.kernel.org/netdev/net-next/c/668b6a2ef832 - [net-next,v4,2/2] net/sched: cls_flower: add support for matching tunnel control flags https://git.kernel.org/netdev/net-next/c/1d17568e74de You are awesome, thank you!
Ilya says: "for correct matching on decapsulated packets, we should match on not only tunnel id and headers, but also on tunnel configuration flags like TUNNEL_NO_CSUM and TUNNEL_DONT_FRAGMENT. This is done to distinguish similar tunnels with slightly different configs. And it is important since tunnel configuration is flow based, i.e. can be different for every packet, even though the main tunnel port is the same." - patch 1 extends the kernel's flow dissector to extract these flags from the packet's tunnel metadata. - patch 2 extends TC flower to match on any combination of TUNNEL_NO_CSUM, TUNNEL_DONT_FRAGMENT, TUNNEL_OAM, TUNNEL_CRIT_OPT v4: - fix kernel-doc warning in flow_dissector.h (thanks Jakub) v3: - rebase on top of new uAPI bits and internals after commit 5832c4a77d69 ("ip_tunnel: convert __be16 tunnel flags to bitmaps"). Use of network byte order is no more needed, since these bits match on metadata: convert netlink attributes to be u32. - also include TUNNEL_CRIT_OPT v2: - use NL_REQ_ATTR_CHECK() where possible (thanks Jamal) - don't overwrite 'ret' in the error path of fl_set_key_flags() Davide Caratti (2): flow_dissector: add support for tunnel control flags net/sched: cls_flower: add support for matching tunnel control flags include/net/flow_dissector.h | 9 ++++++ include/net/ip_tunnels.h | 12 ++++++++ include/uapi/linux/pkt_cls.h | 3 ++ net/core/flow_dissector.c | 16 ++++++++++- net/sched/cls_flower.c | 56 +++++++++++++++++++++++++++++++++++- 5 files changed, 94 insertions(+), 2 deletions(-)