mbox series

[net-next,v3,0/2] bnxt_en: ethtool: Improve wildcard l4proto on ip4/ip6 ntuple rules

Message ID cover.1730778566.git.dxu@dxuuu.xyz (mailing list archive)
Headers show
Series bnxt_en: ethtool: Improve wildcard l4proto on ip4/ip6 ntuple rules | expand

Message

Daniel Xu Nov. 5, 2024, 4:13 a.m. UTC
This patchset improves wildcarding over l4proto on ip4 and ip6 nutple
rules. Previous support required setting l4proto explicitly to 0xFF if
you wanted wildcard, which ethtool (naturally) did not do. For example,
this command would fail with -EOPNOSUPP:

    ethtool -N eth0 flow-type ip6 dst-ip $IP6 context 1

After this patchset, only TCP, UDP, ICMP, and unset will be supported
for l4proto.

Changes from v2:
* Target net-next
* Remove Fixes: tag
* Remove support for IPPROTO_RAW (0xFF) l4proto

Changes from v1:
* Set underlying l4proto to IPPROTO_RAW to fix get path

Daniel Xu (2):
  bnxt_en: ethtool: Remove ip4/ip6 ntuple support for IPPROTO_RAW
  bnxt_en: ethtool: Support unset l4proto on ip4/ip6 ntuple rules

 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 44 +++++++++++--------
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.h |  1 +
 2 files changed, 26 insertions(+), 19 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 7, 2024, 2 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  4 Nov 2024 21:13:18 -0700 you wrote:
> This patchset improves wildcarding over l4proto on ip4 and ip6 nutple
> rules. Previous support required setting l4proto explicitly to 0xFF if
> you wanted wildcard, which ethtool (naturally) did not do. For example,
> this command would fail with -EOPNOSUPP:
> 
>     ethtool -N eth0 flow-type ip6 dst-ip $IP6 context 1
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/2] bnxt_en: ethtool: Remove ip4/ip6 ntuple support for IPPROTO_RAW
    https://git.kernel.org/netdev/net-next/c/050eb2cebb9e
  - [net-next,v3,2/2] bnxt_en: ethtool: Support unset l4proto on ip4/ip6 ntuple rules
    https://git.kernel.org/netdev/net-next/c/5f143efd3804

You are awesome, thank you!