From patchwork Thu Feb 20 01:19:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peilin Ye X-Patchwork-Id: 13983153 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CB7222F19 for ; Thu, 20 Feb 2025 01:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740014381; cv=none; b=UmwxEAp+gyZn8cprqRWHpcgL9A2McYxEWM6VRScQNRlmJRfJAPnAA/DnKX8rZYtMHOHAzR+P1MixK1YVVbrgXdvZ2RuAXPyUr5HwlHWnIpazjJ/U20BiRHsvJRilZWqwFLTVeZvb1JvdvHg0agECRfmKItUqHgmTGdaCQBUnFN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740014381; c=relaxed/simple; bh=68PALQCn4GZXaMAk1aLisnfmMzWgQ+ys526kWmI63g0=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Ii2WuKue7jsapXwLWeHcMYJv6aSvvJaOsiHHBdJswaLfnOgYl1KqW+a42pNXbKLNTL1W+wCLqJkcxCILG+g/TZ95UItI8eAAkUAUXIampUpwNTTIisjV3MZYvW2UFQj96HZZ88yeki6el1pLbroB4AvkD6OafNZB1MeCSZjUWnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--yepeilin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jxWF3k/d; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--yepeilin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jxWF3k/d" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2fc1e7efe00so1058162a91.2 for ; Wed, 19 Feb 2025 17:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740014379; x=1740619179; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=90DsHdVzBzjp5RPvlkSTbOgHqDCYIc4EKhmpQ2T52VA=; b=jxWF3k/dx7RYp+Gz7MuzQy2gRYXQaR79d3X2v+rrYLssejTtuayarnzfx6UikRt2Qt 6i7VfEnLTkNyDTXtMnDXqJ0SIieTaY0EebKq9J82pzsLG6Zop+Rfd4SeI9fN/HT97MGp uXLERB02YfJj4L94M8GawnYTja4bMJrvhgUrlX/2gH+IH1mMQcL7QMohCE84D3wEp1YV 3gmdVci+w2n0co0TujjLgVOk5yYxsy4SD2wPzgA6uO7xLUro2t05sm/NiTAqD9zFrbOU ujDb4mMgSYenSB1a4qBsHkh/ATdWVu66yDLYo8awcLjpglIu8Ov0HkXrXpa10roeX+Ai AeqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740014379; x=1740619179; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=90DsHdVzBzjp5RPvlkSTbOgHqDCYIc4EKhmpQ2T52VA=; b=PIWXjfONr7ebODaZWy5Do7zzgFkP6cqaGxDuWjYy0+p8GpL+33ypF5q1ABvenUz000 zh+rJDhk8pKT/KSgsF3UXJl3j23SimRpxggCYs6wA0stiuxInEfxvKlWzpZNCWvJyehn mF6Fc0aenLvQSsr9tX+b9eOWBmKPaS4l6IQCvgHEYLeBJ0B494WyZgzIBsDa4FZ8WmHk J+1oFtBhxNWiPLcL75LOLgX9OMGA3cqWebOTyWVgfdwQur+p/UPJPq5fz7h3GjGG3rvW mcONnhzNJnd3/0Mdezzo2TwhLBDraOmHRwZlcf8/t/WO55VkoCMjJevDIjB7KIJ9KErz f3XQ== X-Gm-Message-State: AOJu0YzgvY57p14YS/HiWvTeqrTJZszZNPyiV5KMGuPSJcsbexm7Rsb1 YOWkOB5eQiAPj2wkIQZ4WnloZrG0DVB5747waphUiAbz4cCMiD38USR+Cs+FWaaFz9ZpRDPhnt/ /O1LwOHJdbAJv+PmsSYYNdQFN4ISqf10/ENioSyZI5QCDHdW3u0qj3Hm8HWLgGOvqqlEPt/3NUa 9bIX7ip6sM25dMh8GCKBHko4201wZkHpv/CbGnoZU= X-Google-Smtp-Source: AGHT+IHTZJIfwdAPmaRcC/AMICF8Oev4ATVZBir52JFY3k0h8M5BqldtCyuNDkfc9kCd9Vz6uKu+/MDd0uXK1g== X-Received: from pjbpv10.prod.google.com ([2002:a17:90b:3c8a:b0:2d8:8340:8e46]) (user=yepeilin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2887:b0:2f9:bcd8:da33 with SMTP id 98e67ed59e1d1-2fc40f23246mr28257178a91.21.1740014378820; Wed, 19 Feb 2025 17:19:38 -0800 (PST) Date: Thu, 20 Feb 2025 01:19:27 +0000 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.48.1.601.g30ceb7b040-goog Message-ID: Subject: [PATCH bpf-next v3 0/9] Introduce load-acquire and store-release BPF instructions From: Peilin Ye To: bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Peilin Ye , bpf@ietf.org, Xu Kuohai , Eduard Zingerman , David Vernet , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jonathan Corbet , "Paul E. McKenney" , Puranjay Mohan , Ilya Leoshkevich , Heiko Carstens , Vasily Gorbik , Catalin Marinas , Will Deacon , Quentin Monnet , Mykola Lysenko , Shuah Khan , Ihor Solodrai , Yingchi Long , Josh Don , Barret Rhoden , Neel Natu , Benjamin Segall , linux-kernel@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net Hi all! This patchset adds kernel support for BPF load-acquire and store-release instructions (for background, please see [1]), mainly including core/verifier, arm64 JIT compiler, and Documentation/ changes. x86-64 and riscv64 are also planned to be supported. The corresponding LLVM changes can be found at: [2] https://github.com/llvm/llvm-project/pull/108636 Tested using PLATFORM=aarch64 CROSS_COMPILE=aarch64-linux-gnu- vmtest.sh, with llvm-17, llvm-18 and [2]. Please refer to the LLVM PR and individual kernel patches for details. Feedback is much appreciated! v2: https://lore.kernel.org/bpf/cover.1738888641.git.yepeilin@google.com/ v2..v3 notable changes: o (Alexei) change encoding to BPF_LOAD_ACQ=0x100, BPF_STORE_REL=0x110 o add Acked-by: tags from Ilya and Eduard o make new selftests depend on: * __clang_major__ >= 18, and * ENABLE_ATOMICS_TESTS is defined (currently this means -mcpu=v3 or v4), and * JIT supports load_acq/store_rel (currenty only arm64) o work around llvm-17 CI job failure by conditionally define __arena_global variables as 64-bit if __clang_major__ < 18, to make sure .addr_space.1 has no holes o add Google copyright notice in new files v1: https://lore.kernel.org/all/cover.1737763916.git.yepeilin@google.com/ v1..v2 notable changes: o (Eduard) for x86 and s390, make bpf_jit_supports_insn(..., /*in_arena=*/true) return false for load_acq/store_rel o add Eduard's Acked-by: tag o (Eduard) extract LDX and non-ATOMIC STX handling into helpers, see PATCH v2 3/9 o allow unpriv programs to store-release pointers to stack o (Alexei) make it clearer in the interpreter code (PATCH v2 4/9) that only W and DW are supported for atomic RMW o test misaligned load_acq/store_rel o (Eduard) other selftests/ changes: * test load_acq/store_rel with !atomic_ptr_type_ok() pointers: - PTR_TO_CTX, for is_ctx_reg() - PTR_TO_PACKET, for is_pkt_reg() - PTR_TO_FLOW_KEYS, for is_flow_key_reg() - PTR_TO_SOCKET, for is_sk_reg() * drop atomics/ tests * delete unnecessary 'pid' checks from arena_atomics/ tests * avoid depending on __BPF_FEATURE_LOAD_ACQ_STORE_REL, use __imm_insn() and inline asm macros instead RFC v1: https://lore.kernel.org/all/cover.1734742802.git.yepeilin@google.com RFC v1..v1 notable changes: o 1-2/8: minor verifier.c refactoring patches o 3/8: core/verifier changes * (Eduard) handle load-acquire properly in backtrack_insn() * (Eduard) avoid skipping checks (e.g., bpf_jit_supports_insn()) for load-acquires * track the value stored by store-releases, just like how non-atomic STX instructions are handled * (Eduard) add missing link in commit message * (Eduard) always print 'r' for disasm.c changes o 4/8: arm64/insn: avoid treating load_acq/store_rel as load_ex/store_ex o 5/8: arm64/insn: add load_acq/store_rel * (Xu) include Should-Be-One (SBO) bits in "mask" and "value", to avoid setting fixed bits during runtime (JIT-compile time) o 6/8: arm64 JIT compiler changes * (Xu) use emit_a64_add_i() for "pointer + offset" to optimize code emission o 7/8: selftests * (Eduard) avoid adding new tests to the 'test_verifier' runner * add more tests, e.g., checking mark_precise logic o 8/8: instruction-set.rst changes [1] https://lore.kernel.org/all/20240729183246.4110549-1-yepeilin@google.com/ Thanks, Peilin Ye (9): bpf/verifier: Factor out atomic_ptr_type_ok() bpf/verifier: Factor out check_atomic_rmw() bpf/verifier: Factor out check_load_mem() and check_store_reg() bpf: Introduce load-acquire and store-release instructions arm64: insn: Add BIT(23) to {load,store}_ex's mask arm64: insn: Add load-acquire and store-release instructions bpf, arm64: Support load-acquire and store-release instructions selftests/bpf: Add selftests for load-acquire and store-release instructions bpf, docs: Update instruction-set.rst for load-acquire and store-release instructions .../bpf/standardization/instruction-set.rst | 78 ++++-- arch/arm64/include/asm/insn.h | 12 +- arch/arm64/lib/insn.c | 29 ++ arch/arm64/net/bpf_jit.h | 20 ++ arch/arm64/net/bpf_jit_comp.c | 87 +++++- arch/s390/net/bpf_jit_comp.c | 14 +- arch/x86/net/bpf_jit_comp.c | 4 + include/linux/bpf.h | 15 + include/linux/filter.h | 2 + include/uapi/linux/bpf.h | 3 + kernel/bpf/core.c | 63 ++++- kernel/bpf/disasm.c | 12 + kernel/bpf/verifier.c | 234 +++++++++++----- tools/include/uapi/linux/bpf.h | 3 + .../selftests/bpf/prog_tests/arena_atomics.c | 66 ++++- .../selftests/bpf/prog_tests/verifier.c | 4 + .../selftests/bpf/progs/arena_atomics.c | 118 +++++++- .../bpf/progs/verifier_load_acquire.c | 197 +++++++++++++ .../selftests/bpf/progs/verifier_precision.c | 48 ++++ .../bpf/progs/verifier_store_release.c | 264 ++++++++++++++++++ 20 files changed, 1165 insertions(+), 108 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/verifier_load_acquire.c create mode 100644 tools/testing/selftests/bpf/progs/verifier_store_release.c