| Message ID | 07566ce40d155d88b60c643fee2d030989037405.1637264172.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a6366b13c165e5d8d8b06d8d732a4f98bfb8ef66 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ipa: Use 'for_each_clear_bit' when possible | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 18 Nov 2021 20:37:15 +0100 you wrote: > Use 'for_each_clear_bit()' instead of hand writing it. It is much less > version. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/net/ipa/ipa_mem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Here is the summary with links: - net: ipa: Use 'for_each_clear_bit' when possible https://git.kernel.org/netdev/net-next/c/a6366b13c165 You are awesome, thank you!
On 11/18/21 1:37 PM, Christophe JAILLET wrote: > Use 'for_each_clear_bit()' instead of hand writing it. It is much less > version. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> I know this just got committed, but thanks, this is a good improvement. -Alex > --- > drivers/net/ipa/ipa_mem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c > index 4337b0920d3d..1e9eae208e44 100644 > --- a/drivers/net/ipa/ipa_mem.c > +++ b/drivers/net/ipa/ipa_mem.c > @@ -266,9 +266,7 @@ static bool ipa_mem_valid(struct ipa *ipa, const struct ipa_mem_data *mem_data) > } > > /* Now see if any required regions are not defined */ > - for (mem_id = find_first_zero_bit(regions, IPA_MEM_COUNT); > - mem_id < IPA_MEM_COUNT; > - mem_id = find_next_zero_bit(regions, IPA_MEM_COUNT, mem_id + 1)) { > + for_each_clear_bit(mem_id, regions, IPA_MEM_COUNT) { > if (ipa_mem_id_required(ipa, mem_id)) > dev_err(dev, "required memory region %u missing\n", > mem_id); >
diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c index 4337b0920d3d..1e9eae208e44 100644 --- a/drivers/net/ipa/ipa_mem.c +++ b/drivers/net/ipa/ipa_mem.c @@ -266,9 +266,7 @@ static bool ipa_mem_valid(struct ipa *ipa, const struct ipa_mem_data *mem_data) } /* Now see if any required regions are not defined */ - for (mem_id = find_first_zero_bit(regions, IPA_MEM_COUNT); - mem_id < IPA_MEM_COUNT; - mem_id = find_next_zero_bit(regions, IPA_MEM_COUNT, mem_id + 1)) { + for_each_clear_bit(mem_id, regions, IPA_MEM_COUNT) { if (ipa_mem_id_required(ipa, mem_id)) dev_err(dev, "required memory region %u missing\n", mem_id);
Use 'for_each_clear_bit()' instead of hand writing it. It is much less version. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ipa/ipa_mem.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)