diff mbox series

[PATCHv2,net-next] dn_route: set rt neigh to blackhole_netdev instead of loopback_dev in ifdown

Message ID 0cdf10e5a4af509024f08644919121fb71645bc2.1652751029.git.lucien.xin@gmail.com (mailing list archive)
State Accepted
Commit 9cc341286e99a268e63efc6e937d4c467bcf386c
Delegated to: Netdev Maintainers
Headers show
Series [PATCHv2,net-next] dn_route: set rt neigh to blackhole_netdev instead of loopback_dev in ifdown | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers warning 5 maintainers not CCed: pabeni@redhat.com linux-decnet-user@lists.sourceforge.net zhengyongjun3@huawei.com keescook@chromium.org yajun.deng@linux.dev
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Xin Long May 17, 2022, 1:30 a.m. UTC
Like other places in ipv4/6 dst ifdown, change to use blackhole_netdev
instead of pernet loopback_dev in dn dst ifdown.

v1->v2:
  - remove the improper fixes tag as Eric noticed.
  - aim at net-next.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
 net/decnet/dn_route.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski May 18, 2022, 1:04 a.m. UTC | #1
On Mon, 16 May 2022 21:30:29 -0400 Xin Long wrote:
> Like other places in ipv4/6 dst ifdown, change to use blackhole_netdev
> instead of pernet loopback_dev in dn dst ifdown.
> 
> v1->v2:
>   - remove the improper fixes tag as Eric noticed.
>   - aim at net-next.

nit for future patches - now that we add links to the posting when
applying you can put the changelog under the --- delimiter.

> Signed-off-by: Xin Long <lucien.xin@gmail.com>
patchwork-bot+netdevbpf@kernel.org May 18, 2022, 1:10 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 16 May 2022 21:30:29 -0400 you wrote:
> Like other places in ipv4/6 dst ifdown, change to use blackhole_netdev
> instead of pernet loopback_dev in dn dst ifdown.
> 
> v1->v2:
>   - remove the improper fixes tag as Eric noticed.
>   - aim at net-next.
> 
> [...]

Here is the summary with links:
  - [PATCHv2,net-next] dn_route: set rt neigh to blackhole_netdev instead of loopback_dev in ifdown
    https://git.kernel.org/netdev/net-next/c/9cc341286e99

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index d1d78a463a06..552a53f1d5d0 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -159,7 +159,7 @@  static void dn_dst_ifdown(struct dst_entry *dst, struct net_device *dev, int how
 		struct neighbour *n = rt->n;
 
 		if (n && n->dev == dev) {
-			n->dev = dev_net(dev)->loopback_dev;
+			n->dev = blackhole_netdev;
 			dev_hold(n->dev);
 			dev_put(dev);
 		}