| Message ID | 0f880ee706a5478c7d8835a8f7aa15d3c0d916e3.1626256421.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 99bb2ebab953435852340cdb198c5abbf0bb5dd3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: dsa: mv88e6xxx: NET_DSA_MV88E6XXX_PTP should depend on NET_DSA_MV88E6XXX | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Wed, Jul 14, 2021 at 11:58:12AM +0200, Geert Uytterhoeven wrote: > Making global2 support mandatory removed the Kconfig symbol > NET_DSA_MV88E6XXX_GLOBAL2. This symbol also served as an intermediate > symbol to make NET_DSA_MV88E6XXX_PTP depend on NET_DSA_MV88E6XXX. With > the symbol removed, the user is always asked about PTP support for > Marvell 88E6xxx switches, even if the latter support is not enabled. > > Fix this by reinstating the dependency. > > Fixes: 63368a7416df144b ("net: dsa: mv88e6xxx: Make global2 support mandatory") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 14 Jul 2021 11:58:12 +0200 you wrote: > Making global2 support mandatory removed the Kconfig symbol > NET_DSA_MV88E6XXX_GLOBAL2. This symbol also served as an intermediate > symbol to make NET_DSA_MV88E6XXX_PTP depend on NET_DSA_MV88E6XXX. With > the symbol removed, the user is always asked about PTP support for > Marvell 88E6xxx switches, even if the latter support is not enabled. > > Fix this by reinstating the dependency. > > [...] Here is the summary with links: - [v2] net: dsa: mv88e6xxx: NET_DSA_MV88E6XXX_PTP should depend on NET_DSA_MV88E6XXX https://git.kernel.org/netdev/net/c/99bb2ebab953 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/dsa/mv88e6xxx/Kconfig b/drivers/net/dsa/mv88e6xxx/Kconfig index 05af632b0f597da9..634a48e6616b953a 100644 --- a/drivers/net/dsa/mv88e6xxx/Kconfig +++ b/drivers/net/dsa/mv88e6xxx/Kconfig @@ -12,7 +12,7 @@ config NET_DSA_MV88E6XXX config NET_DSA_MV88E6XXX_PTP bool "PTP support for Marvell 88E6xxx" default n - depends on PTP_1588_CLOCK + depends on NET_DSA_MV88E6XXX && PTP_1588_CLOCK help Say Y to enable PTP hardware timestamping on Marvell 88E6xxx switch chips that support it.
Making global2 support mandatory removed the Kconfig symbol NET_DSA_MV88E6XXX_GLOBAL2. This symbol also served as an intermediate symbol to make NET_DSA_MV88E6XXX_PTP depend on NET_DSA_MV88E6XXX. With the symbol removed, the user is always asked about PTP support for Marvell 88E6xxx switches, even if the latter support is not enabled. Fix this by reinstating the dependency. Fixes: 63368a7416df144b ("net: dsa: mv88e6xxx: Make global2 support mandatory") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- v2: - Add Reviewed-by. --- drivers/net/dsa/mv88e6xxx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)