| Message ID | 160141006897.25201.12095049414156293265.stgit@john-Precision-5820-Tower (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c810b31ecb036b94629726d6219ad21b0c7a64a2 |
| Headers | show |
| Series | [bpf-next] bpf, selftests: fix warning in snprintf_btf where system() call unchecked | expand |
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 29 Sep 2020 13:07:49 -0700 you wrote: > On my systems system() calls are marked with warn_unused_result > apparently. So without error checking we get this warning, > > ./prog_tests/snprintf_btf.c:30:9: warning: ignoring return value > of ‘system’, declared with attribute warn_unused_result[-Wunused-result] > > Also it seems like a good idea to check the return value anyways > to ensure ping exists even if its seems unlikely. > > [...] Here is the summary with links: - [bpf-next] bpf, selftests: fix warning in snprintf_btf where system() call unchecked https://git.kernel.org/bpf/bpf-next/c/c810b31ecb03 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/testing/selftests/bpf/prog_tests/snprintf_btf.c b/tools/testing/selftests/bpf/prog_tests/snprintf_btf.c index 3c63a7003db4..686b40f11a45 100644 --- a/tools/testing/selftests/bpf/prog_tests/snprintf_btf.c +++ b/tools/testing/selftests/bpf/prog_tests/snprintf_btf.c @@ -27,7 +27,9 @@ void test_snprintf_btf(void) goto cleanup; /* generate receive event */ - (void) system("ping -c 1 127.0.0.1 > /dev/null"); + err = system("ping -c 1 127.0.0.1 > /dev/null"); + if (CHECK(err, "system", "ping failed: %d\n", err)) + goto cleanup; if (bss->skip) { printf("%s:SKIP:no __builtin_btf_type_id\n", __func__);
On my systems system() calls are marked with warn_unused_result apparently. So without error checking we get this warning, ./prog_tests/snprintf_btf.c:30:9: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result[-Wunused-result] Also it seems like a good idea to check the return value anyways to ensure ping exists even if its seems unlikely. Fixes: 076a95f5aff2c ("selftests/bpf: Add bpf_snprintf_btf helper tests") Signed-off-by: John Fastabend <john.fastabend@gmail.com> --- .../selftests/bpf/prog_tests/snprintf_btf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)