| Message ID | 1606737627-29485-1-git-send-email-bongsu.jeon@samsung.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next,1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface | expand |
On Mon, 30 Nov 2020 21:00:27 +0900 Bongsu jeon wrote: > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> All patches in the series should have the same version. If the patch was not changes in the given repost you can add: v3: - no change Or just not mention the version in the changelog. It's also best to provide a cover letter describing what the series does as a whole for series with more than 2 patches.
On Mon, 30 Nov 2020 21:00:27 +0900, Bongsu jeon wrote: > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > --- > > Changes in v2: > -change the compatible name. > -change the const to enum for compatible. > -change the node name to nfc. > > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 32 ++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml:17:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: See https://patchwork.ozlabs.org/patch/1408172 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, Nov 30, 2020 at 09:00:27PM +0900, Bongsu jeon wrote: > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > --- > > Changes in v2: > -change the compatible name. > -change the const to enum for compatible. > -change the node name to nfc. > > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 32 ++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > index cb0b8a5..481bbcc 100644 > --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml > @@ -12,7 +12,10 @@ maintainers: > > properties: > compatible: > - const: samsung,s3fwrn5-i2c > + oneOf: Don't need 'oneOf' here. > + - enum: > + - samsung,s3fwrn5-i2c > + - samsung,s3fwrn82 > > en-gpios: > maxItems: 1 > @@ -47,10 +50,19 @@ additionalProperties: false > required: > - compatible > - en-gpios > - - interrupts > - - reg > - wake-gpios > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: samsung,s3fwrn5-i2c > + then: > + required: > + - interrupts > + - reg > + > examples: > - | > #include <dt-bindings/gpio/gpio.h> > @@ -71,3 +83,17 @@ examples: > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; > }; > }; > + # UART example on Raspberry Pi > + - | > + uart0 { > + status = "okay"; > + > + nfc { > + compatible = "samsung,s3fwrn82"; > + > + en-gpios = <&gpio 20 0>; > + wake-gpios = <&gpio 16 0>; > + > + status = "okay"; > + }; > + }; > -- > 1.9.1 >
On Mon, Nov 30, 2020 at 08:55:42AM -0800, Jakub Kicinski wrote: > On Mon, 30 Nov 2020 21:00:27 +0900 Bongsu jeon wrote: > > From: Bongsu Jeon <bongsu.jeon@samsung.com> > > > > Since S3FWRN82 NFC Chip, The UART interface can be used. > > S3FWRN82 supports I2C and UART interface. > > > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com> > > All patches in the series should have the same version. > > If the patch was not changes in the given repost you can add: > > v3: > - no change > > Or just not mention the version in the changelog. > > It's also best to provide a cover letter describing what the series > does as a whole for series with more than 2 patches. Beside that I received just 1/4 of v2. LKML has one as well: https://lore.kernel.org/lkml/1606737627-29485-1-git-send-email-bongsu.jeon@samsung.com/ Where are the others? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml index cb0b8a5..481bbcc 100644 --- a/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml +++ b/Documentation/devicetree/bindings/net/nfc/samsung,s3fwrn5.yaml @@ -12,7 +12,10 @@ maintainers: properties: compatible: - const: samsung,s3fwrn5-i2c + oneOf: + - enum: + - samsung,s3fwrn5-i2c + - samsung,s3fwrn82 en-gpios: maxItems: 1 @@ -47,10 +50,19 @@ additionalProperties: false required: - compatible - en-gpios - - interrupts - - reg - wake-gpios +allOf: + - if: + properties: + compatible: + contains: + const: samsung,s3fwrn5-i2c + then: + required: + - interrupts + - reg + examples: - | #include <dt-bindings/gpio/gpio.h> @@ -71,3 +83,17 @@ examples: wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>; }; }; + # UART example on Raspberry Pi + - | + uart0 { + status = "okay"; + + nfc { + compatible = "samsung,s3fwrn82"; + + en-gpios = <&gpio 20 0>; + wake-gpios = <&gpio 16 0>; + + status = "okay"; + }; + };