| Message ID | 1618945797-11091-1-git-send-email-loic.poulain@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b8c55ce266dee09b0e359ff9af885eb94e11480a |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: wwan: Fix bit ops double shift | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 4 of 4 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | fail | Errors and warnings before: 6 this patch: 6 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 22 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 20 Apr 2021 21:09:57 +0200 you wrote: > bit operation helpers such as test_bit, clear_bit, etc take bit > position as parameter and not value. Current usage causes double > shift => BIT(BIT(0)). Fix that in wwan_core and mhi_wwan_ctrl. > > Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > [...] Here is the summary with links: - [net-next] net: wwan: Fix bit ops double shift https://git.kernel.org/netdev/net-next/c/b8c55ce266de You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c index 1fc2376..1bc6b69 100644 --- a/drivers/net/wwan/mhi_wwan_ctrl.c +++ b/drivers/net/wwan/mhi_wwan_ctrl.c @@ -7,9 +7,11 @@ #include <linux/wwan.h> /* MHI wwan flags */ -#define MHI_WWAN_DL_CAP BIT(0) -#define MHI_WWAN_UL_CAP BIT(1) -#define MHI_WWAN_RX_REFILL BIT(2) +enum mhi_wwan_flags { + MHI_WWAN_DL_CAP, + MHI_WWAN_UL_CAP, + MHI_WWAN_RX_REFILL, +}; #define MHI_WWAN_MAX_MTU 0x8000 diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c index b618b79..5be5e1e 100644 --- a/drivers/net/wwan/wwan_core.c +++ b/drivers/net/wwan/wwan_core.c @@ -26,7 +26,7 @@ static int wwan_major; #define to_wwan_port(d) container_of(d, struct wwan_port, dev) /* WWAN port flags */ -#define WWAN_PORT_TX_OFF BIT(0) +#define WWAN_PORT_TX_OFF 0 /** * struct wwan_device - The structure that defines a WWAN device
bit operation helpers such as test_bit, clear_bit, etc take bit position as parameter and not value. Current usage causes double shift => BIT(BIT(0)). Fix that in wwan_core and mhi_wwan_ctrl. Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- drivers/net/wwan/mhi_wwan_ctrl.c | 8 +++++--- drivers/net/wwan/wwan_core.c | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-)