| Message ID | 1619429620-52948-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | bonding/alb: return -ENOMEM when kmalloc failed | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Mon, 2021-04-26 at 17:33 +0800, Yang Li wrote: > The driver is using -1 instead of the -ENOMEM defined macro to > specify that a buffer allocation failed. Using the correct error > code is more intuitive. > > Smatch tool warning: > drivers/net/bonding/bond_alb.c:850 rlb_initialize() warn: returning -1 > instead of -ENOMEM is sloppy > > No functional change, just more standardized. [] > diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c [] > @@ -847,7 +847,7 @@ static int rlb_initialize(struct bonding *bond) > > > new_hashtbl = kmalloc(size, GFP_KERNEL); > if (!new_hashtbl) > - return -1; > + return -ENOMEM; > > > spin_lock_bh(&bond->mode_lock); > > Perhaps the bond_alb_initialize call here which uses the return value from this function: drivers/net/bonding/bond_main.c: if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB))) drivers/net/bonding/bond_main.c- return -ENOMEM; should use a store/test/return style instead of a fixed value return. res = bond_alb_initialize(bond, BOND_MODE(bond) == BOND_MODE_ALB); if (res < 0) return res;
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index c3091e0..dad5383 100644 --- a/drivers/net/bonding/bond_alb.c +++ b/drivers/net/bonding/bond_alb.c @@ -847,7 +847,7 @@ static int rlb_initialize(struct bonding *bond) new_hashtbl = kmalloc(size, GFP_KERNEL); if (!new_hashtbl) - return -1; + return -ENOMEM; spin_lock_bh(&bond->mode_lock);
The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Using the correct error code is more intuitive. Smatch tool warning: drivers/net/bonding/bond_alb.c:850 rlb_initialize() warn: returning -1 instead of -ENOMEM is sloppy No functional change, just more standardized. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/bonding/bond_alb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)