| Message ID | 1622540990-102660-1-git-send-email-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7cf85f8caa042db0e33d70dbd72d8b92b1051f93 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | NFC: nci: Remove redundant assignment to len | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: alexs@kernel.org mudongliangabcd@gmail.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On 01/06/2021 11:49, Yang Li wrote: > Variable 'len' is set to conn_info->max_pkt_payload_len but this > value is never read as it is overwritten with a new value later on, > hence it is a redundant assignment and can be removed. > > Clean up the following clang-analyzer warning: > > net/nfc/nci/hci.c:164:3: warning: Value stored to 'len' is never read > [clang-analyzer-deadcode.DeadStores] > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > net/nfc/nci/hci.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c > index 9686514..d6732e5 100644 > --- a/net/nfc/nci/hci.c > +++ b/net/nfc/nci/hci.c > @@ -161,8 +161,6 @@ static int nci_hci_send_data(struct nci_dev *ndev, u8 pipe, > *(u8 *)skb_push(skb, 1) = data_type; > > do { > - len = conn_info->max_pkt_payload_len; > - > /* If last packet add NCI_HFP_NO_CHAINING */ > if (i + conn_info->max_pkt_payload_len - > (skb->len + 1) >= data_len) { > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 1 Jun 2021 17:49:50 +0800 you wrote: > Variable 'len' is set to conn_info->max_pkt_payload_len but this > value is never read as it is overwritten with a new value later on, > hence it is a redundant assignment and can be removed. > > Clean up the following clang-analyzer warning: > > net/nfc/nci/hci.c:164:3: warning: Value stored to 'len' is never read > [clang-analyzer-deadcode.DeadStores] > > [...] Here is the summary with links: - NFC: nci: Remove redundant assignment to len https://git.kernel.org/netdev/net-next/c/7cf85f8caa04 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c index 9686514..d6732e5 100644 --- a/net/nfc/nci/hci.c +++ b/net/nfc/nci/hci.c @@ -161,8 +161,6 @@ static int nci_hci_send_data(struct nci_dev *ndev, u8 pipe, *(u8 *)skb_push(skb, 1) = data_type; do { - len = conn_info->max_pkt_payload_len; - /* If last packet add NCI_HFP_NO_CHAINING */ if (i + conn_info->max_pkt_payload_len - (skb->len + 1) >= data_len) {
Variable 'len' is set to conn_info->max_pkt_payload_len but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed. Clean up the following clang-analyzer warning: net/nfc/nci/hci.c:164:3: warning: Value stored to 'len' is never read [clang-analyzer-deadcode.DeadStores] Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- net/nfc/nci/hci.c | 2 -- 1 file changed, 2 deletions(-)