| Message ID | 1626978065-5239-1-git-send-email-loic.poulain@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 68d1f1d4af188c290087958c75c7b89a816e1137 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | wwan: core: Fix missing RTM_NEWLINK event for default link | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Thu, Jul 22, 2021 at 9:10 PM Loic Poulain <loic.poulain@linaro.org> wrote: > A wwan link created via the wwan_create_default_link procedure is > never notified to the user (RTM_NEWLINK), causing issues with user > tools relying on such event to track network links (NetworkManager). > > This is because the procedure misses a call to rtnl_configure_link(), > which sets the link as initialized and notifies the new link (cf > proper usage in __rtnl_newlink()). > > Cc: stable@vger.kernel.org > Fixes: ca374290aaad ("wwan: core: support default netdev creation") > Suggested-by: Sergey Ryazanov <ryazanov.s.a@gmail.com> > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 22 Jul 2021 20:21:05 +0200 you wrote: > A wwan link created via the wwan_create_default_link procedure is > never notified to the user (RTM_NEWLINK), causing issues with user > tools relying on such event to track network links (NetworkManager). > > This is because the procedure misses a call to rtnl_configure_link(), > which sets the link as initialized and notifies the new link (cf > proper usage in __rtnl_newlink()). > > [...] Here is the summary with links: - wwan: core: Fix missing RTM_NEWLINK event for default link https://git.kernel.org/netdev/net/c/68d1f1d4af18 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c index 3e16c31..674a81d 100644 --- a/drivers/net/wwan/wwan_core.c +++ b/drivers/net/wwan/wwan_core.c @@ -984,6 +984,8 @@ static void wwan_create_default_link(struct wwan_device *wwandev, goto unlock; } + rtnl_configure_link(dev, NULL); /* Link initialized, notify new link */ + unlock: rtnl_unlock();
A wwan link created via the wwan_create_default_link procedure is never notified to the user (RTM_NEWLINK), causing issues with user tools relying on such event to track network links (NetworkManager). This is because the procedure misses a call to rtnl_configure_link(), which sets the link as initialized and notifies the new link (cf proper usage in __rtnl_newlink()). Cc: stable@vger.kernel.org Fixes: ca374290aaad ("wwan: core: support default netdev creation") Suggested-by: Sergey Ryazanov <ryazanov.s.a@gmail.com> Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- drivers/net/wwan/wwan_core.c | 2 ++ 1 file changed, 2 insertions(+)