From patchwork Sun Aug 15 20:15:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 12437365 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_HEADER_CTYPE_ONLY, SPF_HELO_NONE,SPF_PASS,T_TVD_MIME_NO_HEADERS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19225C43214 for ; Sun, 15 Aug 2021 20:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9C4E60EE2 for ; Sun, 15 Aug 2021 20:15:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhHOUQZ (ORCPT ); Sun, 15 Aug 2021 16:16:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbhHOUQY (ORCPT ); Sun, 15 Aug 2021 16:16:24 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2758C061764 for ; Sun, 15 Aug 2021 13:15:53 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id c4so2309140plh.7 for ; Sun, 15 Aug 2021 13:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9/mONj0q27snMY+u1qDGcrbPRL7b9LK06+7DLvHbLjc=; b=alxhxwDCG2Xdgl6g8TjtfZhpZZpJRd9VYispm3J5PCXR6L//f+IQIh4GOwoF0LWsU7 Tlrbl1BTC/fmDtMxXBdRyNEROt520IYfF79LWxUG8yUkUYFX8DTeKXNE+Kvv0GtAhxGr 2O6fbe9IPS+NTgrZWQNuWQUca9Es71ZcRGybo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9/mONj0q27snMY+u1qDGcrbPRL7b9LK06+7DLvHbLjc=; b=GQdAn3b7tcSNJVkV3Q1fb3hIyljkarV+NlbmbPT7nqOLhLhTWFa/HJHaRV736qzLXO AJM+y0Y+Q4a1lnX9SgMr2VxZ2t6HesyQV7WAMogViGI5/KRjpKvQjLJVnq2BRfAJY4Or SD+yW+LLoY3MWCBA5V+SqVcRKsZOHPCUlxa3fVNBXK15guRsQyVS2DTJstfjyEZzfShw JD5n6hE/hY2fQQ2zmGgUntYAcFff6O2GUpf/8xoluNMFnaEi1/nmRbF/KRz7e+UfEHNT Zr8nJxhGvYrJOAQBjxMUN164ejSsfmpUhbLa70BHq4or1mat63Vs65njTjGQb35H3ibX TLlw== X-Gm-Message-State: AOAM531b+hqUfJ1rHczPpuYGhhbx5A32QI4TObqFwLThwL2vm6zbeLzq pNvYFPktWokMM3DrHtYWhM1+Yw== X-Google-Smtp-Source: ABdhPJwYpZMwvBWd7X7f0/bsU7yTKi0YSeaBGn2aLBCy3NmyrRC8nhSi3lUFc+617o0KfYMd8LqK4g== X-Received: by 2002:aa7:8185:0:b029:3aa:29a2:39d3 with SMTP id g5-20020aa781850000b02903aa29a239d3mr12945863pfi.28.1629058553330; Sun, 15 Aug 2021 13:15:53 -0700 (PDT) Received: from localhost.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id n18sm9098510pfu.3.2021.08.15.13.15.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Aug 2021 13:15:53 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com Subject: [PATCH net 1/2] bnxt_en: Disable aRFS if running on 212 firmware Date: Sun, 15 Aug 2021 16:15:36 -0400 Message-Id: <1629058537-23284-2-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1629058537-23284-1-git-send-email-michael.chan@broadcom.com> References: <1629058537-23284-1-git-send-email-michael.chan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org 212 firmware broke aRFS, so disable it. Traffic may stop after ntuple filters are inserted and deleted by the 212 firmware. Fixes: ae10ae740ad2 ("bnxt_en: Add new hardware RFS mode.") Reviewed-by: Pavan Chebbi Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index dd2d2a5fef15..207ef7dc9bff 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -10792,6 +10792,9 @@ static bool bnxt_rfs_supported(struct bnxt *bp) return true; return false; } + /* 212 firmware is broken for aRFS */ + if (BNXT_FW_MAJ(bp) == 212) + return false; if (BNXT_PF(bp) && !BNXT_CHIP_TYPE_NITRO_A0(bp)) return true; if (bp->flags & BNXT_FLAG_NEW_RSS_CAP)