| Message ID | 1643933373-6590-2-git-send-email-jdamato@fastly.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | page_pool: Add page_pool stat counters | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 3 of 3 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 18 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Thu, Feb 03, 2022 at 04:09:23PM -0800, Joe Damato wrote: > Control enabling / disabling page_pool_stats with a kernel config option. > Option is defaulted to N. > > Signed-off-by: Joe Damato <jdamato@fastly.com> > --- > net/Kconfig | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/net/Kconfig b/net/Kconfig > index 8a1f9d0..604b3eb 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -434,6 +434,18 @@ config NET_DEVLINK > config PAGE_POOL > bool > > +config PAGE_POOL_STATS > + default n > + bool "Page pool stats" > + depends on PAGE_POOL > + help > + Enable page pool statistics to track allocations. Stats are exported > + to the file /proc/net/page_pool_stat. Users can examine these There's no proc anymore > + stats to better understand how their drivers and the kernel's > + page allocator, and the page pool interact with each other. > + > + If unsure, say N. > + > config FAILOVER > tristate "Generic failover module" > help > -- > 2.7.4 > Regards /Ilias
On Thu, Feb 3, 2022 at 11:42 PM Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > On Thu, Feb 03, 2022 at 04:09:23PM -0800, Joe Damato wrote: > > Control enabling / disabling page_pool_stats with a kernel config option. > > Option is defaulted to N. > > > > Signed-off-by: Joe Damato <jdamato@fastly.com> > > --- > > net/Kconfig | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/net/Kconfig b/net/Kconfig > > index 8a1f9d0..604b3eb 100644 > > --- a/net/Kconfig > > +++ b/net/Kconfig > > @@ -434,6 +434,18 @@ config NET_DEVLINK > > config PAGE_POOL > > bool > > > > +config PAGE_POOL_STATS > > + default n > > + bool "Page pool stats" > > + depends on PAGE_POOL > > + help > > + Enable page pool statistics to track allocations. Stats are exported > > + to the file /proc/net/page_pool_stat. Users can examine these > > There's no proc anymore Ah, yes. Thanks :) I've fixed this in my v5 branch.
diff --git a/net/Kconfig b/net/Kconfig index 8a1f9d0..604b3eb 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -434,6 +434,18 @@ config NET_DEVLINK config PAGE_POOL bool +config PAGE_POOL_STATS + default n + bool "Page pool stats" + depends on PAGE_POOL + help + Enable page pool statistics to track allocations. Stats are exported + to the file /proc/net/page_pool_stat. Users can examine these + stats to better understand how their drivers and the kernel's + page allocator, and the page pool interact with each other. + + If unsure, say N. + config FAILOVER tristate "Generic failover module" help
Control enabling / disabling page_pool_stats with a kernel config option. Option is defaulted to N. Signed-off-by: Joe Damato <jdamato@fastly.com> --- net/Kconfig | 12 ++++++++++++ 1 file changed, 12 insertions(+)