diff mbox series

[bpf-next,1/2] bpf: Add some description about BPF_JIT_ALWAYS_ON in Kconfig

Message ID 1644569851-20859-2-git-send-email-yangtiezhu@loongson.cn (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series Modify BPF_JIT_ALWAYS_ON and BPF_JIT_DEFAULT_ON | expand

Checks

Context Check Description
bpf/vmtest-bpf-next success VM_Test
bpf/vmtest-bpf-next-PR success PR summary
netdev/tree_selection success Clearly marked for bpf-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Series has a cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 9 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Tiezhu Yang Feb. 11, 2022, 8:57 a.m. UTC
When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
set to 1 and setting any other value than that will return in failure.

Add the above description in the help text of BPF_JIT_ALWAYS_ON, and then
we can distinguish between BPF_JIT_ALWAYS_ON and BPF_JIT_DEFAULT_ON.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 kernel/bpf/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Daniel Borkmann Feb. 11, 2022, 2:44 p.m. UTC | #1
On 2/11/22 9:57 AM, Tiezhu Yang wrote:
> When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
> set to 1 and setting any other value than that will return in failure.
> 
> Add the above description in the help text of BPF_JIT_ALWAYS_ON, and then
> we can distinguish between BPF_JIT_ALWAYS_ON and BPF_JIT_DEFAULT_ON.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
>   kernel/bpf/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
> index d24d518..88409f8 100644
> --- a/kernel/bpf/Kconfig
> +++ b/kernel/bpf/Kconfig
> @@ -58,6 +58,9 @@ config BPF_JIT_ALWAYS_ON
>   	  Enables BPF JIT and removes BPF interpreter to avoid speculative
>   	  execution of BPF instructions by the interpreter.
>   
> +	  When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
> +	  set to 1 and setting any other value than that will return in failure.

Small nit here: lets use the full path (/proc/sys/net/core/bpf_jit_enable) in order
to be consistent with the other descriptions in this Kconfig.

>   config BPF_JIT_DEFAULT_ON
>   	def_bool ARCH_WANT_DEFAULT_BPF_JIT || BPF_JIT_ALWAYS_ON
>   	depends on HAVE_EBPF_JIT && BPF_JIT
>
diff mbox series

Patch

diff --git a/kernel/bpf/Kconfig b/kernel/bpf/Kconfig
index d24d518..88409f8 100644
--- a/kernel/bpf/Kconfig
+++ b/kernel/bpf/Kconfig
@@ -58,6 +58,9 @@  config BPF_JIT_ALWAYS_ON
 	  Enables BPF JIT and removes BPF interpreter to avoid speculative
 	  execution of BPF instructions by the interpreter.
 
+	  When CONFIG_BPF_JIT_ALWAYS_ON is enabled, bpf_jit_enable is permanently
+	  set to 1 and setting any other value than that will return in failure.
+
 config BPF_JIT_DEFAULT_ON
 	def_bool ARCH_WANT_DEFAULT_BPF_JIT || BPF_JIT_ALWAYS_ON
 	depends on HAVE_EBPF_JIT && BPF_JIT