[net-next,v2] flow_offload: improve extack msg for user when adding invalid filter

Commit Message

Baowen Zheng March 2, 2022, 3:29 a.m. UTC

Add extack message to return exact message to user when adding invalid
filter with conflict flags for TC action.

In previous implement we just return EINVAL which is confusing for user.

Signed-off-by: Baowen Zheng <[e-mail]>
Reviewed-by: Roi Dayan <[e-mail]>
---
 net/sched/act_api.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

[e-mail] March 3, 2022, 6:40 a.m. UTC | #1

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[e-mail]>:

On Wed,  2 Mar 2022 11:29:29 +0800 you wrote:
> Add extack message to return exact message to user when adding invalid
> filter with conflict flags for TC action.
> 
> In previous implement we just return EINVAL which is confusing for user.
> 
> Signed-off-by: Baowen Zheng <[e-mail]>
> Reviewed-by: Roi Dayan <[e-mail]>
> 
> [...]

Here is the summary with links:
  - [net-next,v2] flow_offload: improve extack msg for user when adding invalid filter
    https://git.kernel.org/netdev/net-next/c/d922a99b96d0

You are awesome, thank you!

Patch

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index ca03e72..4f51094 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -1446,6 +1446,8 @@  int tcf_action_init(struct net *net, struct tcf_proto *tp, struct nlattr *nla,
 				continue;
 			if (skip_sw != tc_act_skip_sw(act->tcfa_flags) ||
 			    skip_hw != tc_act_skip_hw(act->tcfa_flags)) {
+				NL_SET_ERR_MSG(extack,
+					       "Mismatch between action and filter offload flags");
 				err = -EINVAL;
 				goto err;
 			}