| Message ID | 1700930098-5483-1-git-send-email-sbhatta@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] octeontx2-af: Check return value of nix_get_nixlf before using nixlf | expand |
On Sat, 25 Nov 2023 22:04:58 +0530 Subbaraya Sundeep wrote: > If a NIXLF is not attached to a PF/VF device then > nix_get_nixlf function fails and returns proper error > code. But npc_get_default_entry_action does not check it > and uses garbage value in subsequent calls. Fix this > by cheking the return value of nix_get_nixlf. > > Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature") You need to run the patch thru scripts/get_maintainer, here you missed CCing Naveen, who authored 967db3529eca. Also lcherian@marvell.com and jerinj@marvell.com LMK if these people are no longer at marvell, I can add their addresses to our ignore list. Same goes for the pauseparam patch, you'll need to repost the two.
Hi Jakub, >-----Original Message----- >From: Jakub Kicinski <kuba@kernel.org> >Sent: Tuesday, November 28, 2023 8:32 AM >To: Subbaraya Sundeep Bhatta <sbhatta@marvell.com> >Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; >davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil >Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula ><gakula@marvell.com>; Hariprasad Kelam <hkelam@marvell.com> >Subject: [EXT] Re: [PATCH net] octeontx2-af: Check return value of >nix_get_nixlf before using nixlf > >---------------------------------------------------------------------- >On Sat, 25 Nov 2023 22:04:58 +0530 Subbaraya Sundeep wrote: >> If a NIXLF is not attached to a PF/VF device then nix_get_nixlf >> function fails and returns proper error code. But >> npc_get_default_entry_action does not check it and uses garbage value >> in subsequent calls. Fix this by cheking the return value of >> nix_get_nixlf. >> >> Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc >> packet replication feature") > >You need to run the patch thru scripts/get_maintainer, here you missed CCing >Naveen, who authored 967db3529eca. >Also lcherian@marvell.com and jerinj@marvell.com LMK if these people are >no longer at marvell, I can add their addresses to our ignore list. > >Same goes for the pauseparam patch, you'll need to repost the two. Sure will do it. Thanks, Sundeep >-- >pw-bot: cr
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c index 16cfc80..f658058 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c @@ -389,7 +389,13 @@ static u64 npc_get_default_entry_action(struct rvu *rvu, struct npc_mcam *mcam, int bank, nixlf, index; /* get ucast entry rule entry index */ - nix_get_nixlf(rvu, pf_func, &nixlf, NULL); + if (nix_get_nixlf(rvu, pf_func, &nixlf, NULL)) { + dev_err(rvu->dev, "%s: nixlf not attached to pcifunc:0x%x\n", + __func__, pf_func); + /* Action 0 is drop */ + return 0; + } + index = npc_get_nixlf_mcam_index(mcam, pf_func, nixlf, NIXLF_UCAST_ENTRY); bank = npc_get_bank(mcam, index);
If a NIXLF is not attached to a PF/VF device then nix_get_nixlf function fails and returns proper error code. But npc_get_default_entry_action does not check it and uses garbage value in subsequent calls. Fix this by cheking the return value of nix_get_nixlf. Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature") Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com> --- drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)