diff mbox series

[v1,net] net: dsa: microchip: fix RGMII error in KSZ DSA driver

Message ID 1717119511-3401-1-git-send-email-Tristram.Ha@microchip.com (mailing list archive)
State Accepted
Commit 278d65ccdadb5f0fa0ceaf7b9cc97b305cd72822
Delegated to: Netdev Maintainers
Headers show
Series [v1,net] net: dsa: microchip: fix RGMII error in KSZ DSA driver | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/apply success Patch already applied to net-0

Commit Message

Tristram.Ha@microchip.com May 31, 2024, 1:38 a.m. UTC 
From: Tristram Ha <tristram.ha@microchip.com>

The driver should return RMII interface when XMII is running in RMII mode.

Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Acked-by: Jerry Ray <jerry.ray@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
v1
- Add review from Andrew Lunn

 drivers/net/dsa/microchip/ksz_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 31, 2024, 10:01 p.m. UTC | #1 
Hello:

This patch was applied to bpf/bpf.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 30 May 2024 18:38:31 -0700 you wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
> 
> The driver should return RMII interface when XMII is running in RMII mode.
> 
> Fixes: 0ab7f6bf1675 ("net: dsa: microchip: ksz9477: use common xmii function")
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
> Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> Acked-by: Jerry Ray <jerry.ray@microchip.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> 
> [...]

Here is the summary with links:
  - [v1,net] net: dsa: microchip: fix RGMII error in KSZ DSA driver
    https://git.kernel.org/bpf/bpf/c/278d65ccdadb

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 1e0085cd9a9a..2818e24e2a51 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -3142,7 +3142,7 @@  phy_interface_t ksz_get_xmii(struct ksz_device *dev, int port, bool gbit)
 		else
 			interface = PHY_INTERFACE_MODE_MII;
 	} else if (val == bitval[P_RMII_SEL]) {
-		interface = PHY_INTERFACE_MODE_RGMII;
+		interface = PHY_INTERFACE_MODE_RMII;
 	} else {
 		interface = PHY_INTERFACE_MODE_RGMII;
 		if (data8 & P_RGMII_ID_EG_ENABLE)