| Message ID | 1718349548-28697-1-git-send-email-shradhagupta@linux.microsoft.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e275e19c918b502aa4534e56dc2e25b5095e9005 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: mana: Use mana_cleanup_port_context() for rxq cleanup | expand |
On Fri, Jun 14, 2024 at 12:19:08AM -0700, Shradha Gupta wrote: > > To cleanup rxqs in port context structures, instead of duplicating the > code, use existing function mana_cleanup_port_context() which does > the exact cleanup that's needed. > > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com> Thanks for following-up with this clean-up, much appreciated. Reviewed-by: Simon Horman <horms@kernel.org>
On Fri, Jun 14, 2024 at 12:19:08AM -0700, Shradha Gupta wrote: > > To cleanup rxqs in port context structures, instead of duplicating the > code, use existing function mana_cleanup_port_context() which does > the exact cleanup that's needed. > > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com> Reviewed-by: Wei Liu <wei.liu@kernel.org>
在 2024/6/14 下午3:19, Shradha Gupta 写道: > To cleanup rxqs in port context structures, instead of duplicating the > code, use existing function mana_cleanup_port_context() which does > the exact cleanup that's needed. > > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com> > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index b89ad4afd66e..93e526e5dd16 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -2529,8 +2529,7 @@ static int mana_init_port(struct net_device *ndev) > return 0; > > reset_apc: > - kfree(apc->rxqs); > - apc->rxqs = NULL; > + mana_cleanup_port_context(apc); > return err; > } > > @@ -2787,8 +2786,7 @@ static int mana_probe_port(struct mana_context *ac, int port_idx, > free_indir: > mana_cleanup_indir_table(apc); > reset_apc: > - kfree(apc->rxqs); > - apc->rxqs = NULL; > + mana_cleanup_port_context(apc); > free_net: > *ndev_storage = NULL; > netdev_err(ndev, "Failed to probe vPort %d: %d\n", port_idx, err); Reviewed-by: Heng Qi <hengqi@linux.alibaba.com> Thanks!
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 14 Jun 2024 00:19:08 -0700 you wrote: > To cleanup rxqs in port context structures, instead of duplicating the > code, use existing function mana_cleanup_port_context() which does > the exact cleanup that's needed. > > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com> > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Here is the summary with links: - [net-next] net: mana: Use mana_cleanup_port_context() for rxq cleanup https://git.kernel.org/netdev/net-next/c/e275e19c918b You are awesome, thank you!
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index b89ad4afd66e..93e526e5dd16 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -2529,8 +2529,7 @@ static int mana_init_port(struct net_device *ndev) return 0; reset_apc: - kfree(apc->rxqs); - apc->rxqs = NULL; + mana_cleanup_port_context(apc); return err; } @@ -2787,8 +2786,7 @@ static int mana_probe_port(struct mana_context *ac, int port_idx, free_indir: mana_cleanup_indir_table(apc); reset_apc: - kfree(apc->rxqs); - apc->rxqs = NULL; + mana_cleanup_port_context(apc); free_net: *ndev_storage = NULL; netdev_err(ndev, "Failed to probe vPort %d: %d\n", port_idx, err);
To cleanup rxqs in port context structures, instead of duplicating the code, use existing function mana_cleanup_port_context() which does the exact cleanup that's needed. Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com> --- drivers/net/ethernet/microsoft/mana/mana_en.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)