| Message ID | 1722417367-4113948-4-git-send-email-radhey.shyam.pandey@amd.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f83828a0522fc57b244629844fc413e38cde95f3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: axienet: Fix coding style issues | expand |
On Wed, Jul 31, 2024 at 02:46:06PM +0530, Radhey Shyam Pandey wrote: > remove unnecessary ftrace-like logging. Also fixes below > checkpatch WARNING. > > WARNING: Unnecessary ftrace-like logging - prefer using ftrace > + dev_dbg(&ndev->dev, "%s\n", __func__); > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 7a89d4fbc884..f8381a56eae6 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1515,8 +1515,6 @@ static int axienet_open(struct net_device *ndev) int ret; struct axienet_local *lp = netdev_priv(ndev); - dev_dbg(&ndev->dev, "%s\n", __func__); - /* When we do an Axi Ethernet reset, it resets the complete core * including the MDIO. MDIO must be disabled before resetting. * Hold MDIO bus lock to avoid MDIO accesses during the reset. @@ -1577,8 +1575,6 @@ static int axienet_stop(struct net_device *ndev) struct axienet_local *lp = netdev_priv(ndev); int i; - dev_dbg(&ndev->dev, "axienet_close()\n"); - if (!lp->use_dmaengine) { napi_disable(&lp->napi_tx); napi_disable(&lp->napi_rx);
remove unnecessary ftrace-like logging. Also fixes below checkpatch WARNING. WARNING: Unnecessary ftrace-like logging - prefer using ftrace + dev_dbg(&ndev->dev, "%s\n", __func__); Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com> --- Changes for v2: - Split each coding style change into separate patch. --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ---- 1 file changed, 4 deletions(-)