| Message ID | 1ef3f2fcd31bd681a193b1fcf235eee1603819bd.1645674068.git.lucien.xin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cd33bdcbead882c2e58fdb4a54a7bd75b610a452 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] ping: remove pr_err from ping_lookup | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 23 Feb 2022 22:41:08 -0500 you wrote: > As Jakub noticed, prints should be avoided on the datapath. > Also, as packets would never come to the else branch in > ping_lookup(), remove pr_err() from ping_lookup(). > > Fixes: 35a79e64de29 ("ping: fix the dif and sdif check in ping_lookup") > Reported-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Xin Long <lucien.xin@gmail.com> > > [...] Here is the summary with links: - [net] ping: remove pr_err from ping_lookup https://git.kernel.org/netdev/net/c/cd33bdcbead8 You are awesome, thank you!
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 3a5994b50571..3ee947557b88 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -187,7 +187,6 @@ static struct sock *ping_lookup(struct net *net, struct sk_buff *skb, u16 ident) (int)ident, &ipv6_hdr(skb)->daddr, dif); #endif } else { - pr_err("ping: protocol(%x) is not supported\n", ntohs(skb->protocol)); return NULL; }
As Jakub noticed, prints should be avoided on the datapath. Also, as packets would never come to the else branch in ping_lookup(), remove pr_err() from ping_lookup(). Fixes: 35a79e64de29 ("ping: fix the dif and sdif check in ping_lookup") Reported-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Xin Long <lucien.xin@gmail.com> --- net/ipv4/ping.c | 1 - 1 file changed, 1 deletion(-)