| Message ID | 20201001225440.1373233-1-sdf@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cffcdbff70a3cf3cc4f42fa2e57012411b1c78a6 |
| Headers | show |
| Series | [bpf-next] selftests/bpf: initialize duration in xdp_noinline.c | expand |
On Thu, Oct 01, 2020 at 03:54:40PM -0700, Stanislav Fomichev wrote: > Fixes clang error: > tools/testing/selftests/bpf/prog_tests/xdp_noinline.c:35:6: error: variable 'duration' is uninitialized when used here [-Werror,-Wuninitialized] > if (CHECK(!skel, "skel_open_and_load", "failed\n")) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Stanislav Fomichev <sdf@google.com> > --- > tools/testing/selftests/bpf/prog_tests/xdp_noinline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c b/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c > index a1f06424cf83..0281095de266 100644 > --- a/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c > +++ b/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c > @@ -25,7 +25,7 @@ void test_xdp_noinline(void) > __u8 flags; > } real_def = {.dst = MAGIC_VAL}; > __u32 ch_key = 11, real_num = 3; > - __u32 duration, retval, size; > + __u32 duration = 0, retval, size; Acked-by: Martin KaFai Lau <kafai@fb.com>
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 1 Oct 2020 15:54:40 -0700 you wrote: > Fixes clang error: > tools/testing/selftests/bpf/prog_tests/xdp_noinline.c:35:6: error: variable 'duration' is uninitialized when used here [-Werror,-Wuninitialized] > if (CHECK(!skel, "skel_open_and_load", "failed\n")) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Stanislav Fomichev <sdf@google.com> > > [...] Here is the summary with links: - [bpf-next] selftests/bpf: initialize duration in xdp_noinline.c https://git.kernel.org/bpf/bpf-next/c/cffcdbff70a3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c b/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c index a1f06424cf83..0281095de266 100644 --- a/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c +++ b/tools/testing/selftests/bpf/prog_tests/xdp_noinline.c @@ -25,7 +25,7 @@ void test_xdp_noinline(void) __u8 flags; } real_def = {.dst = MAGIC_VAL}; __u32 ch_key = 11, real_num = 3; - __u32 duration, retval, size; + __u32 duration = 0, retval, size; int err, i; __u64 bytes = 0, pkts = 0; char buf[128];
Fixes clang error: tools/testing/selftests/bpf/prog_tests/xdp_noinline.c:35:6: error: variable 'duration' is uninitialized when used here [-Werror,-Wuninitialized] if (CHECK(!skel, "skel_open_and_load", "failed\n")) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Stanislav Fomichev <sdf@google.com> --- tools/testing/selftests/bpf/prog_tests/xdp_noinline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)