| Message ID | 20201113135012.32499-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ipv6: remove unused function ipv6_skb_idev() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/source_inline | success | Was 1 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote: > Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the > ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since > then, ipv6_skb_idev() is unused and make CC=clang W=1 warns: > > net/ipv6/exthdrs.c:909:33: > warning: unused function 'ipv6_skb_idev' [-Wunused-function] > > So, remove this unused function and a -Wunused-function warning. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> > --- > Alexey, Hideaki-san, please ack. > > David, Jakub, please pick this minor non-urgent clean-up patch. > > net/ipv6/exthdrs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c > index 374105e4394f..584d1b06eb90 100644 > --- a/net/ipv6/exthdrs.c > +++ b/net/ipv6/exthdrs.c > @@ -906,10 +906,6 @@ void ipv6_exthdrs_exit(void) > /* > * Note: we cannot rely on skb_dst(skb) before we assign it in ip6_route_input(). > */ > -static inline struct inet6_dev *ipv6_skb_idev(struct sk_buff *skb) > -{ > - return skb_dst(skb) ? ip6_dst_idev(skb_dst(skb)) : __in6_dev_get(skb->dev); > -} > > static inline struct net *ipv6_skb_net(struct sk_buff *skb) > { > -- > 2.17.1 >
On Fri, 13 Nov 2020 11:36:49 -0700 Nathan Chancellor wrote: > On Fri, Nov 13, 2020 at 02:50:12PM +0100, Lukas Bulwahn wrote: > > Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the > > ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since > > then, ipv6_skb_idev() is unused and make CC=clang W=1 warns: > > > > net/ipv6/exthdrs.c:909:33: > > warning: unused function 'ipv6_skb_idev' [-Wunused-function] > > > > So, remove this unused function and a -Wunused-function warning. > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Applied, thanks!
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index 374105e4394f..584d1b06eb90 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6/exthdrs.c @@ -906,10 +906,6 @@ void ipv6_exthdrs_exit(void) /* * Note: we cannot rely on skb_dst(skb) before we assign it in ip6_route_input(). */ -static inline struct inet6_dev *ipv6_skb_idev(struct sk_buff *skb) -{ - return skb_dst(skb) ? ip6_dst_idev(skb_dst(skb)) : __in6_dev_get(skb->dev); -} static inline struct net *ipv6_skb_net(struct sk_buff *skb) {
Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since then, ipv6_skb_idev() is unused and make CC=clang W=1 warns: net/ipv6/exthdrs.c:909:33: warning: unused function 'ipv6_skb_idev' [-Wunused-function] So, remove this unused function and a -Wunused-function warning. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- Alexey, Hideaki-san, please ack. David, Jakub, please pick this minor non-urgent clean-up patch. net/ipv6/exthdrs.c | 4 ---- 1 file changed, 4 deletions(-)