| Message ID | 20201127123621.31234-1-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1] net: phy: micrel: fix interrupt handling | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote: > After migration to the shared interrupt support, the KSZ8031 PHY with > enabled interrupt support was not able to notify about link status > change. > > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> I took a quick look at all the other patches like this. I did not spot any other missing the ! Andrew
On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote: > On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote: > > After migration to the shared interrupt support, the KSZ8031 PHY with > > enabled interrupt support was not able to notify about link status > > change. > > > > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback") > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > I took a quick look at all the other patches like this. I did not spot > any other missing the ! > > Andrew Uhh, really sorry for this! Thanks for double checking. Ioana
On Fri, 27 Nov 2020 15:11:08 +0000 Ioana Ciornei wrote: > On Fri, Nov 27, 2020 at 03:45:45PM +0100, Andrew Lunn wrote: > > On Fri, Nov 27, 2020 at 01:36:21PM +0100, Oleksij Rempel wrote: > > > After migration to the shared interrupt support, the KSZ8031 PHY with > > > enabled interrupt support was not able to notify about link status > > > change. > > > > > > Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback") > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > > > I took a quick look at all the other patches like this. I did not spot > > any other missing the ! > > > > Andrew > > Uhh, really sorry for this! > > Thanks for double checking. Applied, thanks!
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 97f08f20630b..54e0d75203da 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -207,7 +207,7 @@ static irqreturn_t kszphy_handle_interrupt(struct phy_device *phydev) return IRQ_NONE; } - if ((irq_status & KSZPHY_INTCS_STATUS)) + if (!(irq_status & KSZPHY_INTCS_STATUS)) return IRQ_NONE; phy_trigger_machine(phydev);
After migration to the shared interrupt support, the KSZ8031 PHY with enabled interrupt support was not able to notify about link status change. Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/micrel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)