| Message ID | 20201130002135.6537-3-stephen@networkplumber.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5bdc4e9151a19f0bc8c851cfcca75363abb19fde |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | Fix compiler warnings from GCC-10 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c index 3e81aa059cb3..d12fd0558f7d 100644 --- a/ip/iplink_bridge.c +++ b/ip/iplink_bridge.c @@ -74,7 +74,7 @@ static void explain(void) void br_dump_bridge_id(const struct ifla_bridge_id *id, char *buf, size_t len) { - char eaddr[32]; + char eaddr[18]; ether_ntoa_r((const struct ether_addr *)id->addr, eaddr); snprintf(buf, len, "%.2x%.2x.%s", id->prio[0], id->prio[1], eaddr);
Gcc-10 complains about possible string length overflow. This can't happen Ethernet address format is always limited to 18 characters or less. Just resize the temp buffer. Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root") Cc: nikolay@cumulusnetworks.com Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- ip/iplink_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)