diff mbox series

[net] tipc: fix incompatible mtu of transmission

Message ID 20201130025544.3602-1-hoang.h.le@dektech.com.au (mailing list archive)
State Accepted
Delegated to: Netdev Maintainers
Headers show
Series [net] tipc: fix incompatible mtu of transmission | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Clearly marked for net
netdev/subject_prefix success Link
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 30 this patch: 30
netdev/kdoc success Errors and warnings before: 25 this patch: 25
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 30 this patch: 30
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Hoang Huu Le Nov. 30, 2020, 2:55 a.m. UTC 
From: Hoang Le <hoang.h.le@dektech.com.au>

In commit 682cd3cf946b6
("tipc: confgiure and apply UDP bearer MTU on running links"), we
introduced a function to change UDP bearer MTU and applied this new value
across existing per-link. However, we did not apply this new MTU value at
node level. This lead to packet dropped at link level if its size is
greater than new MTU value.

To fix this issue, we also apply this new MTU value for node level.

Fixes: 682cd3cf946b6 ("tipc: confgiure and apply UDP bearer MTU on running links")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
---
 net/tipc/node.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jakub Kicinski Dec. 1, 2020, 11:28 p.m. UTC | #1 
On Mon, 30 Nov 2020 09:55:44 +0700 Hoang Huu Le wrote:
> From: Hoang Le <hoang.h.le@dektech.com.au>
> 
> In commit 682cd3cf946b6
> ("tipc: confgiure and apply UDP bearer MTU on running links"), we
> introduced a function to change UDP bearer MTU and applied this new value
> across existing per-link. However, we did not apply this new MTU value at
> node level. This lead to packet dropped at link level if its size is
> greater than new MTU value.
> 
> To fix this issue, we also apply this new MTU value for node level.
> 
> Fixes: 682cd3cf946b6 ("tipc: confgiure and apply UDP bearer MTU on running links")
> Acked-by: Jon Maloy <jmaloy@redhat.com>
> Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>

Applied, thanks!
diff mbox series

Patch

diff --git a/net/tipc/node.c b/net/tipc/node.c
index cd67b7d5169f..9f6975dd7873 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -2182,6 +2182,8 @@  void tipc_node_apply_property(struct net *net, struct tipc_bearer *b,
 			else if (prop == TIPC_NLA_PROP_MTU)
 				tipc_link_set_mtu(e->link, b->mtu);
 		}
+		/* Update MTU for node link entry */
+		e->mtu = tipc_link_mss(e->link);
 		tipc_node_write_unlock(n);
 		tipc_bearer_xmit(net, bearer_id, &xmitq, &e->maddr, NULL);
 	}