From patchwork Thu Dec 3 10:22:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 11948327 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A567C63777 for ; Thu, 3 Dec 2020 10:23:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A47D21D91 for ; Thu, 3 Dec 2020 10:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727069AbgLCKXU (ORCPT ); Thu, 3 Dec 2020 05:23:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbgLCKXT (ORCPT ); Thu, 3 Dec 2020 05:23:19 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66DB3C061A4E for ; Thu, 3 Dec 2020 02:22:39 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id v12so2068840ybi.6 for ; Thu, 03 Dec 2020 02:22:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=vsqjzCG97dcihSHBib7qbR9auIczQ/SwW03OgCf6BLA=; b=KO9gk6ofgaQ/Jly7j0A1VuJ6WlC1hiy7I+SkR3CY5r4rxRyKJeUQJmvfI/EQno6COp Pd5OebmmiB9NnixUYZFdzXYXFPucr2NFVCJ7nsQLg4JEgZ8uM3j6/SLlKg6hm1FJVOBu vGKFcN2JlhWOB/MmW4n59K6e6vFmIyzDiqEVKgJN+4MitUUEpIXYlefxLkirm+Ji95+9 kWj/WrWvm0TWkh91QmiTAY7BkkiwOMsXCHkbtaPOLWd+z8GpWdK56UOyIDk3JCvz9Wl8 9cKrvOom8gi+fx+rfKBTzI4qnYw3HlJm7SXwg3gonwaCZzLeSdMV/qKKn9pa8x8WNwTZ 2ezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=vsqjzCG97dcihSHBib7qbR9auIczQ/SwW03OgCf6BLA=; b=HVA0z/Z1qXgct1K3lkj+wODghtb4ET3ZJ1HFC2oZCloeg2eHuK2rgxKAkCng+Uwx0t KtGuH+Fql26oRcJifNGzjyIO/RmR+cNnPYjQ7s01PHuDxEVS5Tsgz/gVO3T20qbXgAzS fBlzDTTbcYOcvooG9jh4fNf0MzNPSUIrtnmK19rZeEDzEGPgRWAyhUpvm/mB41ugvmW5 RrvCe7sLeB4Hj2vvc/bG2I5vO7lLe1wZOhKbS4w9Gf7zPVVuqIf7OmXBWtn0zyLqps52 VMZYPuPV6QUKkobWVuaUBJs40bHm5qlSfQwoVsM3+htqonW1OjL9m3gxhnxMMmhDgzBt yezA== X-Gm-Message-State: AOAM532vEMBFttG1qLfDNz+maRQsNT40F+tABsspLCcx4QKBSnrZ3qpg qm7hSq0zWQQKuwuKTi7T3cBYA0maHfQtrTzNzWu/jSLS/3MAz9r6gyyDYMpS3WfgoDzwHldGQ2J fHi+06xNTy4Co3igT1HpZ55cpiwqPyH60WHifLlGbkpQX+hipP4k79gY7xteVvbs= X-Google-Smtp-Source: ABdhPJwtpbLRCdwh6CxXu9InNBnq8+upXgOOu++rmsLwSfcBgI9lS5mLYW0FM3hQKqkKOC18S/foZathvHFdPw== Sender: "jackmanb via sendgmr" X-Received: from beeg.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:11db]) (user=jackmanb job=sendgmr) by 2002:a25:38d2:: with SMTP id f201mr3520867yba.103.1606990958512; Thu, 03 Dec 2020 02:22:38 -0800 (PST) Date: Thu, 3 Dec 2020 10:22:34 +0000 Message-Id: <20201203102234.648540-1-jackmanb@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog Subject: [PATCH bpf-next] tools/resolve_btfids: Fix some error messages From: Brendan Jackman To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , KP Singh , Florent Revest , linux-kernel@vger.kernel.org, Jiri Olsa , Brendan Jackman Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net Add missing newlines and fix polarity of strerror argument. Signed-off-by: Brendan Jackman Acked-by: Jiri Olsa --- tools/bpf/resolve_btfids/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: 97306be45fbe7a02461c3c2a57e666cf662b1aaf diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c index dfa540d8a02d..e3ea569ee125 100644 --- a/tools/bpf/resolve_btfids/main.c +++ b/tools/bpf/resolve_btfids/main.c @@ -454,7 +454,7 @@ static int symbols_collect(struct object *obj) return -ENOMEM; if (id->addr_cnt >= ADDR_CNT) { - pr_err("FAILED symbol %s crossed the number of allowed lists", + pr_err("FAILED symbol %s crossed the number of allowed lists\n", id->name); return -1; } @@ -477,8 +477,8 @@ static int symbols_resolve(struct object *obj) btf = btf__parse(obj->btf ?: obj->path, NULL); err = libbpf_get_error(btf); if (err) { - pr_err("FAILED: load BTF from %s: %s", - obj->path, strerror(err)); + pr_err("FAILED: load BTF from %s: %s\n", + obj->path, strerror(-err)); return -1; }