| Message ID | 20201203160245.1014867-12-jackmanb@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | BPF |
| Headers | show |
| Series | Atomics for eBPF | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/subject_prefix | success | Link |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 1 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | fail | ERROR: Remove Gerrit Change-Id's before submitting upstream ERROR: do not initialise globals to 0 WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Thu, Dec 3, 2020 at 8:08 AM Brendan Jackman <jackmanb@google.com> wrote: > > Change-Id: Ia15bb76f7152fff2974e38242d7430ce2987a71e > See recent discussion on KP's patch set. There needs to be a commit message, even if it's just a copy/paste of subject line. But see also my other reply, I'm not sure it's worth it to do it this way for selftests. > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Quentin Monnet <quentin@isovalent.com> > Cc: "Frank Ch. Eigler" <fche@redhat.com> > Cc: Stephane Eranian <eranian@google.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Thomas Hebb <tommyhebb@gmail.com> > Change-Id: Ie2c3832eaf050d627764071d1927c7546e7c4b4b > Signed-off-by: Brendan Jackman <jackmanb@google.com> > --- > tools/build/feature/Makefile | 4 ++++ > tools/build/feature/test-clang-bpf-atomics.c | 9 +++++++++ > 2 files changed, 13 insertions(+) > create mode 100644 tools/build/feature/test-clang-bpf-atomics.c > > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index cdde783f3018..81370d7fa193 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -70,6 +70,7 @@ FILES= \ > test-libaio.bin \ > test-libzstd.bin \ > test-clang-bpf-co-re.bin \ > + test-clang-bpf-atomics.bin \ > test-file-handle.bin \ > test-libpfm4.bin > > @@ -331,6 +332,9 @@ $(OUTPUT)test-clang-bpf-co-re.bin: > $(CLANG) -S -g -target bpf -o - $(patsubst %.bin,%.c,$(@F)) | \ > grep BTF_KIND_VAR > > +$(OUTPUT)test-clang-bpf-atomics.bin: > + $(CLANG) -S -g -target bpf -mcpu=v3 -Werror=implicit-function-declaration -o - $(patsubst %.bin,%.c,$(@F)) 2>&1 > + > $(OUTPUT)test-file-handle.bin: > $(BUILD) > > diff --git a/tools/build/feature/test-clang-bpf-atomics.c b/tools/build/feature/test-clang-bpf-atomics.c > new file mode 100644 > index 000000000000..8b5fcdd4ba6f > --- /dev/null > +++ b/tools/build/feature/test-clang-bpf-atomics.c > @@ -0,0 +1,9 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (c) 2020 Google > + > +int x = 0; > + > +int foo(void) > +{ > + return __sync_val_compare_and_swap(&x, 1, 2); > +} > -- > 2.29.2.454.gaff20da3a2-goog >
diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile index cdde783f3018..81370d7fa193 100644 --- a/tools/build/feature/Makefile +++ b/tools/build/feature/Makefile @@ -70,6 +70,7 @@ FILES= \ test-libaio.bin \ test-libzstd.bin \ test-clang-bpf-co-re.bin \ + test-clang-bpf-atomics.bin \ test-file-handle.bin \ test-libpfm4.bin @@ -331,6 +332,9 @@ $(OUTPUT)test-clang-bpf-co-re.bin: $(CLANG) -S -g -target bpf -o - $(patsubst %.bin,%.c,$(@F)) | \ grep BTF_KIND_VAR +$(OUTPUT)test-clang-bpf-atomics.bin: + $(CLANG) -S -g -target bpf -mcpu=v3 -Werror=implicit-function-declaration -o - $(patsubst %.bin,%.c,$(@F)) 2>&1 + $(OUTPUT)test-file-handle.bin: $(BUILD) diff --git a/tools/build/feature/test-clang-bpf-atomics.c b/tools/build/feature/test-clang-bpf-atomics.c new file mode 100644 index 000000000000..8b5fcdd4ba6f --- /dev/null +++ b/tools/build/feature/test-clang-bpf-atomics.c @@ -0,0 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright (c) 2020 Google + +int x = 0; + +int foo(void) +{ + return __sync_val_compare_and_swap(&x, 1, 2); +}
Change-Id: Ia15bb76f7152fff2974e38242d7430ce2987a71e Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Quentin Monnet <quentin@isovalent.com> Cc: "Frank Ch. Eigler" <fche@redhat.com> Cc: Stephane Eranian <eranian@google.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Thomas Hebb <tommyhebb@gmail.com> Change-Id: Ie2c3832eaf050d627764071d1927c7546e7c4b4b Signed-off-by: Brendan Jackman <jackmanb@google.com> --- tools/build/feature/Makefile | 4 ++++ tools/build/feature/test-clang-bpf-atomics.c | 9 +++++++++ 2 files changed, 13 insertions(+) create mode 100644 tools/build/feature/test-clang-bpf-atomics.c