| Message ID | 20210106042531.1351-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1f685e6adbbe3c7b1bd9053be771b898d9efa655 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ptp: ptp_ines: prevent build when HAS_IOMEM is not set | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Tue, Jan 05, 2021 at 08:25:31PM -0800, Randy Dunlap wrote: > ptp_ines.c uses devm_platform_ioremap_resource(), which is only > built/available when CONFIG_HAS_IOMEM is enabled. > CONFIG_HAS_IOMEM is not enabled for arch/s390/, so builds on S390 > have a build error: > > s390-linux-ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe': > ptp_ines.c:(.text+0x17e6): undefined reference to `devm_platform_ioremap_resource' > > Prevent builds of ptp_ines.c when HAS_IOMEM is not set. Acked-by: Richard Cochran <richardcochran@gmail.com>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 5 Jan 2021 20:25:31 -0800 you wrote: > ptp_ines.c uses devm_platform_ioremap_resource(), which is only > built/available when CONFIG_HAS_IOMEM is enabled. > CONFIG_HAS_IOMEM is not enabled for arch/s390/, so builds on S390 > have a build error: > > s390-linux-ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe': > ptp_ines.c:(.text+0x17e6): undefined reference to `devm_platform_ioremap_resource' > > [...] Here is the summary with links: - ptp: ptp_ines: prevent build when HAS_IOMEM is not set https://git.kernel.org/netdev/net/c/1f685e6adbbe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
--- lnx-511-rc2.orig/drivers/ptp/Kconfig +++ lnx-511-rc2/drivers/ptp/Kconfig @@ -78,6 +78,7 @@ config DP83640_PHY config PTP_1588_CLOCK_INES tristate "ZHAW InES PTP time stamping IP core" depends on NETWORK_PHY_TIMESTAMPING + depends on HAS_IOMEM depends on PHYLIB depends on PTP_1588_CLOCK help
ptp_ines.c uses devm_platform_ioremap_resource(), which is only built/available when CONFIG_HAS_IOMEM is enabled. CONFIG_HAS_IOMEM is not enabled for arch/s390/, so builds on S390 have a build error: s390-linux-ld: drivers/ptp/ptp_ines.o: in function `ines_ptp_ctrl_probe': ptp_ines.c:(.text+0x17e6): undefined reference to `devm_platform_ioremap_resource' Prevent builds of ptp_ines.c when HAS_IOMEM is not set. Fixes: bad1eaa6ac31 ("ptp: Add a driver for InES time stamping IP core.") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Link: lore.kernel.org/r/202101031125.ZEFCUiKi-lkp@intel.com Cc: Richard Cochran <richardcochran@gmail.com> Cc: netdev@vger.kernel.org Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> --- drivers/ptp/Kconfig | 1 + 1 file changed, 1 insertion(+)