| Message ID | 20210113144309.1384615-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7da17624e7948d5d9660b910f8079d26d26ce453 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nt: usb: USB_RTL8153_ECM should not default to y | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | warning | 4 maintainers not CCed: yuehaibing@huawei.com masahiroy@kernel.org gregkh@linuxfoundation.org andre.edich@microchip.com |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote: > In general, device drivers should not be enabled by default. > > Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/net/usb/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig > index 1e37190287808973..fbbe786436319013 100644 > --- a/drivers/net/usb/Kconfig > +++ b/drivers/net/usb/Kconfig > @@ -631,7 +631,6 @@ config USB_NET_AQC111 > config USB_RTL8153_ECM > tristate "RTL8153 ECM support" > depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n) > - default y > help > This option supports ECM mode for RTL8153 ethernet adapter, when > CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 13 Jan 2021 15:43:09 +0100 you wrote: > In general, device drivers should not be enabled by default. > > Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/net/usb/Kconfig | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - nt: usb: USB_RTL8153_ECM should not default to y https://git.kernel.org/netdev/net/c/7da17624e794 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index 1e37190287808973..fbbe786436319013 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kconfig @@ -631,7 +631,6 @@ config USB_NET_AQC111 config USB_RTL8153_ECM tristate "RTL8153 ECM support" depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n) - default y help This option supports ECM mode for RTL8153 ethernet adapter, when CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
In general, device drivers should not be enabled by default. Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/usb/Kconfig | 1 - 1 file changed, 1 deletion(-)