diff mbox series

NFC: fix possible resource leak

Message ID 20210121153745.122184-1-bianpan2016@163.com (mailing list archive)
State Accepted
Commit d8f923c3ab96dbbb4e3c22d1afc1dc1d3b195cd8
Delegated to: Netdev Maintainers
Headers show
Series NFC: fix possible resource leak | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers warning 1 maintainers not CCed: geliangtang@gmail.com
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Pan Bian Jan. 21, 2021, 3:37 p.m. UTC
Put the device to avoid resource leak on path that the polling flag is
invalid.

Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 net/nfc/netlink.c | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 23, 2021, 9:40 p.m. UTC | #1
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 21 Jan 2021 07:37:45 -0800 you wrote:
> Put the device to avoid resource leak on path that the polling flag is
> invalid.
> 
> Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  net/nfc/netlink.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - NFC: fix possible resource leak
    https://git.kernel.org/netdev/net/c/d8f923c3ab96

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 573b38ad2f8e..e161ef2d4720 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -852,6 +852,7 @@  static int nfc_genl_stop_poll(struct sk_buff *skb, struct genl_info *info)
 
 	if (!dev->polling) {
 		device_unlock(&dev->dev);
+		nfc_put_device(dev);
 		return -EINVAL;
 	}