diff mbox series

net: phy: remove h from printk format specifier

Message ID 20210125164528.2101360-1-trix@redhat.com (mailing list archive)
State Rejected
Delegated to: Netdev Maintainers
Headers show
Series net: phy: remove h from printk format specifier | expand

Checks

Context Check Description
netdev/cover_letter success Link
netdev/fixes_present success Link
netdev/patch_count success Link
netdev/tree_selection success Guessed tree name to be net-next
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/source_inline success Was 0 now: 0
netdev/verify_signedoff success Link
netdev/module_param success Was 0 now: 0
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/verify_fixes success Link
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/header_inline success Link
netdev/stable success Stable not CCed

Commit Message

Tom Rix Jan. 25, 2021, 4:45 p.m. UTC 
From: Tom Rix <trix@redhat.com>

This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
  unnecessary %h[xudi] and %hh[xudi]")

Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xudi] or %h[xudi].

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/phy/dp83640.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Jan. 29, 2021, 2:17 a.m. UTC | #1 
On Mon, 25 Jan 2021 08:45:28 -0800 trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
>   unnecessary %h[xudi] and %hh[xudi]")
> 
> Standard integer promotion is already done and %hx and %hhx is useless
> so do not encourage the use of %hh[xudi] or %h[xudi].
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

As I mentioned before I personally don't care much for these changes so
please expect me to be tossing them out of patchwork silently if the
maintainer does not ack in time. YMMV with Dave (he should be back soon)
diff mbox series

Patch

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 0d79f68f301c..1bc68a3bffa2 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -186,7 +186,7 @@  static void dp83640_gpio_defaults(struct ptp_pin_desc *pd)
 
 	for (i = 0; i < GPIO_TABLE_SIZE; i++) {
 		if (gpio_tab[i] < 1 || gpio_tab[i] > DP83640_N_PINS) {
-			pr_err("gpio_tab[%d]=%hu out of range", i, gpio_tab[i]);
+			pr_err("gpio_tab[%d]=%u out of range", i, gpio_tab[i]);
 			return;
 		}
 	}