| Message ID | 20210127025123.6390-1-hoang.h.le@dektech.com.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2a9063b7fface7e665e9be62e14aa8b0ed207e2f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] tipc: remove duplicated code in tipc_msg_create | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 3 maintainers not CCed: davem@davemloft.net kuba@kernel.org tipc-discussion@lists.sourceforge.net |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 10 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
| netdev/stable | success | Stable not CCed |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 27 Jan 2021 09:51:23 +0700 you wrote: > Remove a duplicate code checking for header size in tipc_msg_create() as > it's already being done in tipc_msg_init(). > > Acked-by: Jon Maloy <jmaloy@redhat.com> > Signed-off-by: Hoang Huu Le <hoang.h.le@dektech.com.au> > --- > net/tipc/msg.c | 4 ---- > 1 file changed, 4 deletions(-) Here is the summary with links: - [net-next] tipc: remove duplicated code in tipc_msg_create https://git.kernel.org/netdev/net-next/c/2a9063b7ffac You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/tipc/msg.c b/net/tipc/msg.c index 2aca86021df5..e9263280a2d4 100644 --- a/net/tipc/msg.c +++ b/net/tipc/msg.c @@ -117,10 +117,6 @@ struct sk_buff *tipc_msg_create(uint user, uint type, msg_set_origport(msg, oport); msg_set_destport(msg, dport); msg_set_errcode(msg, errcode); - if (hdr_sz > SHORT_H_SIZE) { - msg_set_orignode(msg, onode); - msg_set_destnode(msg, dnode); - } return buf; }